Fix multi page rendering by setting global $INFO #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of rendering multiple pages into a single document, the context of the current page does not match the one of the pages to be rendered. In some cases (e.g. with the struct plugin), the global $INFO is evluated and as this is not set to match the page to be rendered, the struct plugin does not produce the expected output in the PDF. Fix this by setting $INFO to match the current page to be rendered and restoring it afterwards. Signed-off-by: Frieder Schrempf <[email protected]>
|
This also fixes the rendering of struct aggregations using variable filters as they also rely on |
|
This code is tested? |
|
I'm hesitating. Should the struct plugin not just use global $ID instead of $INFO['id']? Normally the $ID is updated before specific recursive rendering of pages, and $INFO['id'] is still on the background to know the original page? Only the $INFO['id'] was used? or more properties of the $INFO array? If use of $INFO the right way, then I'm fine merging this. @splitbrain what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of rendering multiple pages into a single document, the context of the current page does not match the one of the pages
to be rendered. In some cases (e.g. with the struct plugin), the global $INFO is evaluated and as this is not set to match the page to be rendered, the struct plugin does not produce the expected output in the PDF.
Fix this by setting $INFO to match the current page to be rendered and restoring it afterwards.
In conjunction with cosmocode/dokuwiki-plugin-struct#574 this fixes the struct data output in multi-page PDFs.