feat!: migrate to allocate previously allocated rewards, and distribute unaccounted denoms #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insumity
commented
Sep 27, 2024
insumity
force-pushed
the
insumity/add-v21-upgrade
branch
from
923b4c2
to
c9c3d93
Compare
insumity
requested review from
zmanian,
crodriguezvega,
jackzampolin and
a team
as code owners
insumity
force-pushed
the
insumity/add-v21-upgrade
branch
from
c9c3d93
to
19aa123
Compare
MSalopek
changed the title
sainoe
reviewed
Sep 30, 2024
sainoe
reviewed
Sep 30, 2024
insumity
commented
Oct 2, 2024
Co-authored-by: Simon Noetzlin <[email protected]>
insumity
force-pushed
the
insumity/add-v21-upgrade
branch
from
14a8bbc
to
c8e711b
Compare
insumity
force-pushed
the
insumity/add-v21-upgrade
branch
from
c8e711b
to
db07de6
Compare
insumity
changed the title
mpoke
requested review from
dasanchez,
LexaMichaelides and
fastfadingviolets
as code owners
This was referenced Oct 3, 2024
Closed
MSalopek
approved these changes
Oct 4, 2024
odeke-em
reviewed
Oct 7, 2024
Comment on lines
+92
to
+95
| if expectedChainID != actualChainID { | ||
| return false | ||
| } | ||
| return true |
There was a problem hiding this comment.
Nit, in the future we can make this simply
return expectedChainID == actualChainID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump).changelog(for details, see contributing guidelines)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change