-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add PR labeler #1204
ci: add PR labeler #1204
Conversation
- Makefile | ||
- Dockerfile | ||
- scripts/* | ||
"C:Testing": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the C:Testing
the label applied when change under app/**/*
, cmd/**/*
etc. If yes, why introduce this label for changes under app
and cmd
? Also, would it be possible to add this label if modification in a _test
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both app/* and cmd/* are only used for testing. Every chain will have its own. Maybe we can have a better split, maybe with a better label. I'll let @p-offtermatt and @MSalopek to suggest something.
All PRs that change the production code should also change the _test files as they will have unit tests. I'm not sure how valuable is to add a special label for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I have an opinion on that yet, I would suggest we see how these labels feel and we can adjust later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we could also just look at what files are changed for a PR and determine these mental notes ourselves, but overall not opposed to these tags. LGTM
Description
Closes: NA
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...