Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add PR labeler #1204

Merged
merged 1 commit into from
Aug 16, 2023
Merged

ci: add PR labeler #1204

merged 1 commit into from
Aug 16, 2023

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Aug 15, 2023

Description

Closes: NA


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@mpoke mpoke requested a review from a team as a code owner August 15, 2023 12:58
- Makefile
- Dockerfile
- scripts/*
"C:Testing":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the C:Testing the label applied when change under app/**/*, cmd/**/* etc. If yes, why introduce this label for changes under app and cmd? Also, would it be possible to add this label if modification in a _test file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both app/* and cmd/* are only used for testing. Every chain will have its own. Maybe we can have a better split, maybe with a better label. I'll let @p-offtermatt and @MSalopek to suggest something.

All PRs that change the production code should also change the _test files as they will have unit tests. I'm not sure how valuable is to add a special label for that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I have an opinion on that yet, I would suggest we see how these labels feel and we can adjust later.

Copy link
Contributor

@insumity insumity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shaspitz shaspitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we could also just look at what files are changed for a PR and determine these mental notes ourselves, but overall not opposed to these tags. LGTM

@mpoke mpoke merged commit cd1818a into main Aug 16, 2023
9 of 12 checks passed
@mpoke mpoke deleted the marius/pr-labeler branch August 16, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants