Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add PR labeler #1204

Merged
merged 1 commit into from
Aug 16, 2023
Merged

ci: add PR labeler #1204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/pr_labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
"C:x/consumer":
- x/ccv/consumer/**/*
"C:x/democracy":
- x/ccv/democracy/**/*
"C:x/provider":
- x/ccv/provider/**/*
"C:x/types":
- x/ccv/types/**/*
"C:Docs":
- docs/docs/**/*
"C:ADR":
- docs/docs/adrs/**/*
"C:CI":
- .github/**/*.yml
- buf.work.yaml
- .mergify.yml
- .golangci.yml
- mlc_config.json
- sonar-project.properties
"C:Build":
- Makefile
- Dockerfile
- scripts/*
"C:Testing":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the C:Testing the label applied when change under app/**/*, cmd/**/* etc. If yes, why introduce this label for changes under app and cmd? Also, would it be possible to add this label if modification in a _test file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both app/* and cmd/* are only used for testing. Every chain will have its own. Maybe we can have a better split, maybe with a better label. I'll let @p-offtermatt and @MSalopek to suggest something.

All PRs that change the production code should also change the _test files as they will have unit tests. I'm not sure how valuable is to add a special label for that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I have an opinion on that yet, I would suggest we see how these labels feel and we can adjust later.

- app/**/*
- cmd/**/*
- legacy_ibc_testing/**/*
- tests/**/*
- testutil/**/*
18 changes: 18 additions & 0 deletions .github/workflows/pr_labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: "Pull Request Labeler"
on:
- pull_request_target

permissions:
contents: read

jobs:
labeler:
permissions:
contents: read # for actions/labeler to determine modified files
pull-requests: write # for actions/labeler to add labels to PRs
runs-on: ubuntu-latest
steps:
- uses: actions/labeler@main
with:
configuration-path: .github/pr_labeler.yml
repo-token: "${{ secrets.GITHUB_TOKEN }}"
Loading