Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update cryptographic feature ADR #1389

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented Nov 3, 2023

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct docs: prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR only changes documentation
  • Reviewed content for consistency
  • Reviewed content for spelling and grammar
  • Tested instructions (if applicable)
  • Checked that the documentation website can be built and deployed successfully (run make build-docs)

@sainoe sainoe requested a review from a team as a code owner November 3, 2023 14:58
@github-actions github-actions bot added C:Testing Assigned automatically by the PR labeler C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler C:x/types Assigned automatically by the PR labeler C:Build Assigned automatically by the PR labeler C:CI Assigned automatically by the PR labeler C:Docs Assigned automatically by the PR labeler C:ADR Assigned automatically by the PR labeler labels Nov 3, 2023
@sainoe sainoe changed the base branch from main to release/v2.2.x-provider-lsm November 3, 2023 14:59
@@ -8,6 +8,7 @@ title: Cryptographic verification of equivocation evidence
* 5/1/2023: First draft
* 7/23/2023: Add light client attacks handling
* 9/6/2023: Add double signing attacks handling
* 11/3/2023: Update limitations to handle amnesia attacks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* 11/3/2023: Update limitations to handle amnesia attacks
* 11/3/2023: Update limitations to clarify amnesia attacks are ignored

This might be better at expressing what was changed in the adr? I didn't get the original changelog line

Copy link
Contributor

@insumity insumity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left nit comment but otherwise looks good to me .

@sainoe sainoe mentioned this pull request Nov 6, 2023
12 tasks
@sainoe sainoe merged commit b778c73 into release/v2.2.x-provider-lsm Nov 6, 2023
7 checks passed
@sainoe sainoe deleted the sainoe/v2.2.x-ADR-update branch November 6, 2023 12:39
mpoke added a commit that referenced this pull request Nov 30, 2023
update ADR

Co-authored-by: Marius Poke <[email protected]>
MSalopek pushed a commit that referenced this pull request Dec 1, 2023
update ADR

Co-authored-by: Marius Poke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:ADR Assigned automatically by the PR labeler C:Build Assigned automatically by the PR labeler C:CI Assigned automatically by the PR labeler C:Docs Assigned automatically by the PR labeler C:Testing Assigned automatically by the PR labeler C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler C:x/types Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants