-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: added more e2e permissionless tests #2262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:Testing
Assigned automatically by the PR labeler
C:CI
Assigned automatically by the PR labeler
labels
Sep 12, 2024
bermuell
force-pushed
the
bernd/permissionless_e2e_new
branch
2 times, most recently
from
September 12, 2024 14:29
941aea2
to
a71bbce
Compare
bermuell
force-pushed
the
bernd/permissionless_e2e_new
branch
from
September 12, 2024 14:34
a71bbce
to
91fac64
Compare
bermuell
commented
Sep 12, 2024
LGTM! |
sainoe
approved these changes
Sep 13, 2024
insumity
reviewed
Sep 13, 2024
insumity
reviewed
Sep 13, 2024
insumity
reviewed
Sep 13, 2024
insumity
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
LGTM
Co-authored-by: insumity <[email protected]>
21 tasks
bermuell
commented
Sep 13, 2024
21 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
* added more e2e permissionless tests * Update tests/e2e/steps_permissionless_ics.go Co-authored-by: insumity <[email protected]> * addressed comments * adapt tests to new behaciour of 'has-to-validate' --------- Co-authored-by: insumity <[email protected]> (cherry picked from commit 5a3227d)
8 tasks
mpoke
added a commit
that referenced
this pull request
Sep 13, 2024
test: added more e2e permissionless tests (#2262) * added more e2e permissionless tests * Update tests/e2e/steps_permissionless_ics.go Co-authored-by: insumity <[email protected]> * addressed comments * adapt tests to new behaciour of 'has-to-validate' --------- Co-authored-by: insumity <[email protected]> (cherry picked from commit 5a3227d) Co-authored-by: bernd-m <[email protected]> Co-authored-by: Marius Poke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add more e2e tests for permissionless
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...