Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: enable the distribution of ICS rewards from Stride #2288

Merged
merged 5 commits into from
Sep 20, 2024
Merged

fix!: enable the distribution of ICS rewards from Stride #2288

merged 5 commits into from
Sep 20, 2024

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Sep 19, 2024

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@mpoke mpoke requested a review from a team as a code owner September 19, 2024 10:31
@github-actions github-actions bot added C:x/provider Assigned automatically by the PR labeler C:x/types Assigned automatically by the PR labeler labels Sep 19, 2024
@mpoke mpoke mentioned this pull request Sep 19, 2024
Closed
21 tasks
@mpoke mpoke mentioned this pull request Sep 19, 2024
Closed
insumity
insumity approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@insumity insumity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MSalopek
MSalopek approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admin

@mpoke mpoke merged commit 18ba837 into main Sep 20, 2024
12 of 13 checks passed
@mpoke mpoke deleted the marius/rewards-ibc-channel2 branch September 20, 2024 16:07
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
@mpoke @mergify
fix!: enable the distribution of ICS rewards from Stride (#2288)
4c445f6 
* enable Stride to distribute ICS rewards

* fix bug in migration

* assign to same consumerId

* add changelog entries

(cherry picked from commit 18ba837)
@mergify mergify bot mentioned this pull request Sep 20, 2024
Merged
21 tasks
mpoke added a commit that referenced this pull request Sep 20, 2024
@mergify @mpoke
fix!: enable the distribution of ICS rewards from Stride (backport #2288
f2303ab 
) (#2302)

fix!: enable the distribution of ICS rewards from Stride (#2288)

* enable Stride to distribute ICS rewards

* fix bug in migration

* assign to same consumerId

* add changelog entries

(cherry picked from commit 18ba837)

Co-authored-by: Marius Poke <[email protected]>
@sainoe sainoe mentioned this pull request Oct 3, 2024
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSalopek MSalopek MSalopek approved these changes

@insumity insumity insumity approved these changes

Assignees
No one assigned
Labels
A:backport/v6.1.x C:x/provider Assigned automatically by the PR labeler C:x/types Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpoke @insumity @MSalopek