More compiler warnings, and sanitizers, in CMake builds #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An inline function (not method!) in a header file shouldn't be declared `static` or it'll be copied into every compilation unit that uses it.
snej
force-pushed
the
warnings
branch
3 times, most recently
from
08f326a
to
93bcdfb
Compare
- Removed `using namespace` at global scope in headers (it pollutes the global namespace for anyone including those headers), then added it in the .cc files that include those headers. - Some 3rd party headers trigger warnings, so wrapped those in pragmas to suppress them. - Marked functions that always throw as `[[noreturn]]`. - Definitions of `operator""` should have a space after the quotes. - Some template instantiations needed to be declared explicitly in headers. - Don't use 0 as a synonym of nullptr.
|
This is probably going to cause more warnings on non clang platforms due to unknown pragmas (clang diagnostic) but it's really just a drop in the bucket when it comes time to actually tackle that and we may well switch to clang everywhere first. |
borrrden
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new CMake options:
FLEECE_WARNINGS_HARDCOREenables all compiler warnings except for a few dozen that are too onerous, plus-Werror.FLEECE_SANITIZEenables the Clang Address and UB sanitizers.Currently these are only supported in Clang builds, and ignored with other compilers.
Also made source changes to fix some of the newly-enabled warnings.