Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15 fmp provider #16

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jaapterwoerds
Copy link
Contributor

@jaapterwoerds jaapterwoerds commented Aug 1, 2021

Here a first version of an implementation of an data provider for https://financialmodelingprep.com/. I factored out most code so that implementing a data provider is basically implementing one function that interacts with the data provider's API.

Feedback is appreciated!

Closes #15

@jaapterwoerds jaapterwoerds force-pushed the 15-fmp-provider branch 3 times, most recently from d2f9d45 to bb67891 Compare September 5, 2021 19:41
@parmarsuraj99 parmarsuraj99 requested a review from jrdi October 4, 2021 17:01
@jaapterwoerds
Copy link
Contributor Author

GIve me a moment to update this PR with changes from master. In addition I want to make changes so that the training data and validation data can make use of as much data as available from the provider (see also #21 )

@jaapterwoerds jaapterwoerds marked this pull request as draft October 12, 2021 20:26
@hellno
Copy link
Contributor

hellno commented Oct 22, 2021

hey :) @jrdi @jaapterwoerds
what's the status on this PR?

I thought about adding AlphaVantage support to opensignals.
Having this PR merged or agreeing on a structure for common code <> data-provider-specific code would help.

Thanks!

@jrdi
Copy link
Collaborator

jrdi commented Oct 22, 2021

hey, imo it would be better if we first do a PR refactoring of the code and move the required code to a common place, then we can start working on other changes adding more providers.

@jaapterwoerds
Copy link
Contributor Author

@jrdi @hellno Sounds like a solid plan. I have some data issues to figure out anyway before this can be usable anyway. I can rework this into a separate PR if you'd like?

@jaapterwoerds
Copy link
Contributor Author

jaapterwoerds commented Oct 22, 2021

@jrdo @hellno This PR seems the simplest first step that could work: #28. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FMP alternative data provider
3 participants