Use poetry for packaging & dependency management #31
Conversation
arnaudgelas
force-pushed
the
dep
branch
3 times, most recently
from
1e4cacc to
d732670
Compare
| if ! command -v poetry &> /dev/null | ||
| then | ||
| echo "poetry is missing. Installing ..." | ||
| curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py | python - |
There was a problem hiding this comment.
executing some remote file is not exactly the safest way of installing things. Any other options of getting poetry, pip install poetry maybe? :-)
There was a problem hiding this comment.
I have never used poetry and I don*t fully get which problem it is solving, especially in case of opensignals. Like there wasn`t anything broken with the setup.py + requirements.txt way of doing things. But I like trying out new things, so why not... Ok from my end.
I*ve added a few comments and let @jrdi decide
| @@ -17,14 +17,14 @@ extension-pkg-whitelist= | |||
| fail-on= | |||
|
|
|||
| # Specify a score threshold to be exceeded before program exits with error. | |||
| fail-under=10.0 | |||
| fail-under=9.0 | |||
There was a problem hiding this comment.
You are making pylint less strict?
| @@ -0,0 +1,19 @@ | |||
| #! /usr/bin/bash | |||
There was a problem hiding this comment.
I assume, we should all run this script to setup our dev environment. Could you add a short section to the README file to explain this?
| - name: Publish distribution 📦 to PyPI | ||
| if: startsWith(github.ref, 'refs/tags') | ||
| uses: pypa/gh-action-pypi-publish@master | ||
| run: poetry publish |
There was a problem hiding this comment.
Do we still need the setup.py and requirements.txt files, I guess they are deprecated with your PR, no?
And is the publish doing the same things, for example is the README used as the description on pypi?
I tend to agree with @uuazed here, I don't fully understand the reason behind the PR and the problem is solving. Anyway, since the effort has been already put into the change, I'll be happy to merge once the comments are addressed. |
No description provided.