fix(ec): pageview will not include action, product and impression #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sallainCoveo
requested review from
jmprovencher,
lbourdages,
aperron-coveo,
rphilippen,
tsteijvers,
AdamMartineau-Coveo,
mpayne-coveo and
samisayegh
and removed request for
a team
aperron-coveo
approved these changes
May 21, 2024
samisayegh
approved these changes
May 22, 2024
sallainCoveo
force-pushed
the
fix-LENS-1826-possible-race-condition-between-pageview-and-detail-events
branch
from
23a0d6d to
cc0b253
Compare
sallainCoveo
deleted the
fix-LENS-1826-possible-race-condition-between-pageview-and-detail-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://coveord.atlassian.net/browse/LENS-1826
The issue described in the Jira, Slack thread and discuss was that sometimes the "event" type event didn't include the product and product action / the "pageview" type event include the product and product action.
It would seems that the order of event that are sent is important, but to prevent the plugin's data to be cleared too soon OR that we include the data to a
pageviewevent, I've added a pageview check.One argument that could be made is to put the emphasis in the documentation that the "event" type should absolutely be sent before the pageview to prevent this problem. However, there's also an argument to be made that maybe the order shouldn't matter (especially when these events were historically coupled together, so more client's implementations might be broken then we think).
Demo of the results:
demo_pageview_not_included_product_and_action.mp4