Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resource): fix search list fields to allow empty pipeline #763

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix(resource): fix search list fields to allow empty pipeline #763

merged 1 commit into from
Nov 2, 2023

Conversation

aboissinot-coveo
Copy link
Contributor

@aboissinot-coveo aboissinot-coveo commented Oct 30, 2023 •
edited by jira bot
Loading

Description

SEARCHAPI-9086

We need to be able to pass the empty pipeline to this call otherwise it's the default pipeline being used when no parameters are passed.

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@aboissinot-coveo aboissinot-coveo marked this pull request as ready for review October 30, 2023 17:40
@aboissinot-coveo aboissinot-coveo requested a review from a team October 30, 2023 17:40
@aboissinot-coveo aboissinot-coveo requested a review from a team as a code owner October 30, 2023 17:40
@aboissinot-coveo aboissinot-coveo merged commit b9cd9d1 into master Nov 2, 2023
5 checks passed
@aboissinot-coveo aboissinot-coveo deleted the SEARCHAPI-9086/fix-emtpy-pipeline branch November 2, 2023 11:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

🎉 This PR is included in version 48.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdostie gdostie gdostie approved these changes

@louis-bompart louis-bompart louis-bompart approved these changes

@GermainBergeron GermainBergeron Awaiting requested review from GermainBergeron

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

@dmgauthier dmgauthier Awaiting requested review from dmgauthier

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aboissinot-coveo @louis-bompart @gdostie