Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(lint): fix CI workflow not linting files #898

Merged
merged 4 commits into from
Dec 18, 2024
Merged

ci(lint): fix CI workflow not linting files #898

merged 4 commits into from
Dec 18, 2024

Conversation

gdostie
Copy link
Contributor

@gdostie gdostie commented Dec 17, 2024

I realized the the CI is somehow not linting files anymore or running prettier, which lead to PRs with faulty code style being merged in the master branch.

This PR does the following:

  1. Add back lint during CI
  2. Lint fix the whole repo
  3. Remove eslint from the lint-staged process. Since we lint in the CI anyways, we don't need to slowdown the pre-commit hook too much.

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@gdostie gdostie requested review from a team as code owners December 17, 2024 22:30
GermainBergeron
GermainBergeron approved these changes Dec 18, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
toofff
toofff approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@toofff toofff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !!!

FelixBlaisThon
FelixBlaisThon approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@FelixBlaisThon FelixBlaisThon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame on me not seeing this, thanks

@gdostie gdostie added this pull request to the merge queue Dec 18, 2024
Merged via the queue into master with commit c992539 Dec 18, 2024
5 checks passed
@gdostie gdostie deleted the ADUI-10444-lint-in-ci branch December 18, 2024 16:45
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 57.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

paulgerold pushed a commit that referenced this pull request Dec 19, 2024
@gdostie @paulgerold
ci(lint): fix CI workflow not linting files (#898)
9c7dfff 
* ci: run lint during CI workflow

* chore(format): run lint fix

* build(lint): stop running eslint on pre-commit

We lint on the CI anyway so no need to slowdown the commit process

* refactor(npm): remove echo in lint script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schaoukicoveo schaoukicoveo schaoukicoveo approved these changes

@FelixBlaisThon FelixBlaisThon FelixBlaisThon approved these changes

@toofff toofff toofff approved these changes

@GermainBergeron GermainBergeron GermainBergeron approved these changes

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/dx

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gdostie @GermainBergeron @toofff @FelixBlaisThon @schaoukicoveo