feat: add arbitrum one #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@cowprotocol/[email protected], npm/@cowprotocol/[email protected] |
alfetopito
added a commit
to cowprotocol/cowswap
that referenced
this pull request
May 15, 2024
alfetopito
added a commit
to cowprotocol/cowswap
that referenced
this pull request
May 15, 2024
This was referenced May 15, 2024
shoom3301
approved these changes
May 15, 2024
anxolin
reviewed
May 16, 2024
|
|
||
| const tokenListsByNetwork: Record<SupportedChainId, string> = { | ||
| [SupportedChainId.MAINNET]: 'CowSwap.json', | ||
| [SupportedChainId.ARBITRUM_ONE]: 'CowSwap.json', |
There was a problem hiding this comment.
At some point, we might want to break by network the lists, right?
There was a problem hiding this comment.
Not sure. I'm inclined to think now that we should keep them all in the same file, except test chains.
There was a problem hiding this comment.
Im fine for now, but if we had 20 chains, and they all had 200 tokens you can easily see how we load data for users they don't need.
Anyways, not a big issue right now, if this is simpler, lets leave it for now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of cowprotocol/cowswap#4310
Testing
For the permit info, I've added it temporarily to CoW Swap.
Try it out on https://swap-dev-git-feat-4310arbitrum-cowswap.vercel.app/
For the token form, this PR needs to be merged first.