-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add arbitrum one #389
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
36965f7
feat: add permit info for arbitrum one
alfetopito 4dc163b
feat: add permitinfo file checked against coingecko list
alfetopito f80b0f1
feat: update templates to allow adding arb1 tokens with gh forms
alfetopito e572a05
chore: update dependencies which support arb1
alfetopito 0cc0bd1
chore: add commands related to arb1
alfetopito 2a83e32
chore: update text
alfetopito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,18 @@ | ||
import { SupportedChainId } from '@cowprotocol/cow-sdk' | ||
import { readFileSync } from 'node:fs' | ||
import { join } from 'node:path' | ||
import { BASE_PATH } from '../const' | ||
import { Token } from '../types' | ||
import { join } from 'node:path' | ||
import { SupportedChainId } from '@cowprotocol/cow-sdk' | ||
|
||
const tokenListsByNetwork: Record<SupportedChainId, string> = { | ||
[SupportedChainId.MAINNET]: 'CowSwap.json', | ||
[SupportedChainId.ARBITRUM_ONE]: 'CowSwap.json', | ||
[SupportedChainId.GNOSIS_CHAIN]: 'CowSwap.json', | ||
[SupportedChainId.SEPOLIA]: 'CowSwapSepolia.json', | ||
} | ||
|
||
export function getTokensFromTokenList(chainId: SupportedChainId, tokenListPath: string | undefined): Array<Token> { | ||
const filePath = tokenListPath | ||
? tokenListPath | ||
: join(BASE_PATH, tokenListsByNetwork[chainId]) | ||
const filePath = tokenListPath ? tokenListPath : join(BASE_PATH, tokenListsByNetwork[chainId]) | ||
|
||
return JSON.parse(readFileSync(filePath, 'utf-8')).tokens | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point, we might want to break by network the lists, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. I'm inclined to think now that we should keep them all in the same file, except test chains.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im fine for now, but if we had 20 chains, and they all had 200 tokens you can easily see how we load data for users they don't need.
Anyways, not a big issue right now, if this is simpler, lets leave it for now