feat(SearchBar): fetch and open note once clicked on a suggestion #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
trollepierre
force-pushed
the
search-bar-redirect-not-v7
branch
from
a4ddb59
to
46b6fe0
Compare
trollepierre
changed the title
trollepierre
force-pushed
the
search-bar-redirect-not-v7
branch
2 times, most recently
from
ae42465
to
ed32b71
Compare
trollepierre
force-pushed
the
search-bar-redirect-not-v7
branch
from
ed32b71
to
561c0a5
Compare
Crash--
approved these changes
Aug 22, 2022
|
🎉 This PR is included in version 7.20.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was detected by:
cozy/cozy-drive#2663
notes URL were not used to redirect, once clicked.
By fixing that bug, I realized the postMessage onSelect function could not be sent through postMessage. Becasue postMessage serializes the object before sending it.
An object could not be cloned
Fetching URL is now done inside Cozy-Bar scope