feat(SearchBar): fetch and open note once clicked on a suggestion #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
trollepierre
force-pushed
the
search-bar-redirect-note
branch
from
a626f20 to
dea25be
Compare
trollepierre
changed the title
Crash--
reviewed
Aug 22, 2022
src/components/Bar.jsx
Outdated
| {barSearch || (searchBarEnabled ? <SearchBar /> : null)} | ||
| {barSearch || | ||
| (searchBarEnabled ? ( | ||
| <SearchBar client={this.props.cozyClient} /> |
There was a problem hiding this comment.
What is the gain to pass client as props? Why not using withClient as the rest of our codebase?
trollepierre
force-pushed
the
search-bar-redirect-note
branch
2 times, most recently
from
19fd238 to
26c634a
Compare
trollepierre
force-pushed
the
search-bar-redirect-note
branch
from
26c634a to
47ef4fc
Compare
Crash--
approved these changes
Aug 22, 2022
|
🎉 This PR is included in version 8.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR description of #773