-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2024-11 LWG Motion 18] P1928R15 std::simd — merge data-parallel types from the Parallelism TS 2 #7440
Conversation
472e4ad
to
943a96d
Compare
|
943a96d
to
a408f67
Compare
I think the second commit is fine as-is. |
\tcode{value} identifies the alignment restrictions on pointers used for | ||
(converting) loads and stores for the given type \tcode{T} on arrays of type | ||
\tcode{U}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That needs a normative statement somewhere. Cross-reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The normative wording is in [simd.ctor] (the range ctor) and [simd.loadstore]. The cross-reference is directly preceding the note. Should it be in the note instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would prefer that, but it's ok either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want the reference repeated? Could you send a follow-up PR if you'd like to have that?
a408f67
to
668fcd6
Compare
8f307b9
to
810743b
Compare
@mattkretz Just to check, this PR only includes the changes in numeric.tex, not the rest of the paper? |
… TS 2 * Add closing parenthesis in [simd.reductions] p3. * Add namespace std to simd_flags, basic_simd, and basic_simd_mask * Add comma after 'e.g.' * Add \rSec3[simd.expos.defn]{Exposition-only helpers} (missing sibling) * Remove \iref from simd.expos.abi] (5.3), already in (5.2) Fixes cplusplus#7430 Fixes cplusplus/papers#670
The return type in the itemdecl/-descr was obviously wrong (ABI tag as first template argument to the simd_mask alias template and missing closing template bracket). The synopsis had the correct return type.
810743b
to
57c9031
Compare
Yes, I completely forgot about the rest of the wording changes for the PR. 😒 |
simd_flags
,basic_simd
, andbasic_simd_mask
\rSec3[simd.expos.defn]{Exposition-only helpers}
(missing sibling)\iref
from simd.expos.abi] (5.3), already in (5.2)Fixes #7430
Fixes cplusplus/papers#670