Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-11 LWG Motion 18] P1928R15 std::simd — merge data-parallel types from the Parallelism TS 2 #7440

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

mattkretz
Copy link
Contributor

  • Add closing parenthesis in [simd.reductions] p3.
  • Add namespace std to simd_flags, basic_simd, and basic_simd_mask
  • Add comma after 'e.g.'
  • Add \rSec3[simd.expos.defn]{Exposition-only helpers} (missing sibling)
  • Remove \iref from simd.expos.abi] (5.3), already in (5.2)

Fixes #7430
Fixes cplusplus/papers#670

@mattkretz mattkretz force-pushed the motion-2024-11-lwg-18 branch from 472e4ad to 943a96d Compare November 25, 2024 15:48
@mattkretz
Copy link
Contributor Author

mattkretz commented Nov 25, 2024

  • I believe the 'Index of implementation-defined behavior' does not list simd yet.
  • Library index is missing
  • Is the second commit sufficiently editorial, or does it need an LWG issue?

@mattkretz mattkretz force-pushed the motion-2024-11-lwg-18 branch from 943a96d to a408f67 Compare November 25, 2024 20:38
@jensmaurer jensmaurer changed the title Merge 2024-11 LWG Motion 18 - P1928R15 std::simd — merge data-parallel types from the Parallelism TS 2 [2024-11 LWG Motion 18] P1928R15 std::simd — merge data-parallel types from the Parallelism TS 2 Dec 4, 2024
@jensmaurer jensmaurer added this to the post-2024-11 milestone Dec 4, 2024
@jensmaurer
Copy link
Member

I think the second commit is fine as-is.

source/numerics.tex Outdated Show resolved Hide resolved
source/numerics.tex Outdated Show resolved Hide resolved
source/numerics.tex Outdated Show resolved Hide resolved
source/numerics.tex Outdated Show resolved Hide resolved
source/numerics.tex Outdated Show resolved Hide resolved
source/numerics.tex Show resolved Hide resolved
source/numerics.tex Outdated Show resolved Hide resolved
Comment on lines +16758 to +16803
\tcode{value} identifies the alignment restrictions on pointers used for
(converting) loads and stores for the given type \tcode{T} on arrays of type
\tcode{U}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That needs a normative statement somewhere. Cross-reference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The normative wording is in [simd.ctor] (the range ctor) and [simd.loadstore]. The cross-reference is directly preceding the note. Should it be in the note instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer that, but it's ok either way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want the reference repeated? Could you send a follow-up PR if you'd like to have that?

source/numerics.tex Outdated Show resolved Hide resolved
source/numerics.tex Outdated Show resolved Hide resolved
@mattkretz mattkretz force-pushed the motion-2024-11-lwg-18 branch from a408f67 to 668fcd6 Compare December 5, 2024 20:14
@tkoeppe tkoeppe force-pushed the motion-2024-11-lwg-18 branch 2 times, most recently from 8f307b9 to 810743b Compare December 17, 2024 16:56
@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 17, 2024

@mattkretz Just to check, this PR only includes the changes in numeric.tex, not the rest of the paper?

… TS 2

* Add closing parenthesis in [simd.reductions] p3.
* Add namespace std to simd_flags, basic_simd, and basic_simd_mask
* Add comma after 'e.g.'
* Add \rSec3[simd.expos.defn]{Exposition-only helpers} (missing sibling)
* Remove \iref from simd.expos.abi] (5.3), already in (5.2)

Fixes cplusplus#7430
Fixes cplusplus/papers#670
The return type in the itemdecl/-descr was obviously wrong (ABI tag as
first template argument to the simd_mask alias template and missing
closing template bracket). The synopsis had the correct return type.
@tkoeppe tkoeppe force-pushed the motion-2024-11-lwg-18 branch from 810743b to 57c9031 Compare December 17, 2024 17:12
@tkoeppe tkoeppe merged commit ef8c8ca into cplusplus:main Dec 17, 2024
2 checks passed
@mattkretz
Copy link
Contributor Author

@mattkretz Just to check, this PR only includes the changes in numeric.tex, not the rest of the paper?

Yes, I completely forgot about the rest of the wording changes for the PR. 😒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants