Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P3379R0 Constrain std::expected equality operators #7449

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

jensmaurer
Copy link
Member

Fixes #7416
Also fixes cplusplus/papers#2036

@jensmaurer jensmaurer added this to the post-2024-11 milestone Nov 27, 2024
@jwakely
Copy link
Member

jwakely commented Nov 27, 2024

Oh dear, it looks like LWG reviewed and approved R0 of this paper. At least this time the poll matched what was reviewed.

The only difference is that R1 says that the __cpp_lib_constrained_equality feature test macro should also be present in <expected>, so when updating [version.syn] (which is missing from this PR) it should also add ", <expected>" to the comment.

Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a missing edit to [version.syn]:

Update the value of the __cpp_lib_constrained_equality feature test macro in [version.syn].

@jensmaurer
Copy link
Member Author

@jwakely , fixed the missing version bump

I think we've decided before that feature-test macros are sort-of editorial, so I've added the <expected> amendment with a separate commit.

@tkoeppe tkoeppe force-pushed the motions-2024-11-lwg-4 branch from 654b6bf to 8926021 Compare December 16, 2024 18:47
@tkoeppe tkoeppe force-pushed the motions-2024-11-lwg-4 branch from 8926021 to dbbef7f Compare December 16, 2024 20:18
@tkoeppe tkoeppe merged commit 8df8512 into main Dec 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants