Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp] Correctly identify preprocessor tokens vs, tokens #7482

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

AlisdairM
Copy link
Contributor

Most references to tokens in [cpp] correctly refer to preprocessing tokens that a materially different thng to a regular token. This commit addresses the last few places referring to a plain token where they should instead be referring to a preprocessing token. The remining usage of plain token where evaludating the predicate to directives is intentional, and trying to change to a preproccessing token would be an actual error.

Most references to tokens in [cpp] correctly refer to preprocessing
tokens that a materially different thng to a regular token.  This
commit addresses the last few places referring to a plain token
where they should instead be referring to a preprocessing token.
The remining usage of plain token where evaludating the predicate
to  directives is intentional, and trying to change to a
preproccessing token would be an actual error.
@tkoeppe tkoeppe merged commit 7fe908f into cplusplus:main Dec 17, 2024
2 checks passed
@AlisdairM AlisdairM deleted the cpp_preprocessing_tokens branch December 17, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants