[meta.reflection.extract] rm second constexpr if #8349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please read https://github.com/cplusplus/draft/wiki/Commit-message-format in its entirety, adjust the commit message, and force-push. |
jensmaurer
added
changes requested
JeffGarland
changed the title
jwakely
approved these changes
Oct 20, 2025
|
The commit message is still missing "Fixes US 113-173 (C++26 CD)." Having this in the pull request is good, but not enough. And we don't want "also fixes", because this is a genuine editorial issue, not an application of a paper or LWG/CWG issue resolution (as approved by plenary). And while we're at it, "rm" is not an English word. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes US 113-173 (C++26 CD)
Fixes cplusplus/nbballot#991