466 bug fix for group level scoring def, and concurrent mod exception #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting check succeeded! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #479 +/- ##
============================================
+ Coverage 61.96% 62.00% +0.04%
- Complexity 3548 3552 +4
============================================
Files 328 328
Lines 17576 17574 -2
Branches 2707 2707
============================================
+ Hits 10891 10897 +6
+ Misses 5476 5472 -4
+ Partials 1209 1205 -4 ☔ View full report in Codecov by Sentry. |
JPercival
approved these changes
Jun 11, 2024
| if (!measure.hasImprovementNotation()) { | ||
| ourLog.info("Measure does not specify an improvement notation so skipping: {}.", measure.getId()); | ||
| measures.remove(measure); | ||
| ourLog.info( |
There was a problem hiding this comment.
thought: This is the type of validation we should push upstream. Then we can give specific feedback in an OperationOutcome about issues with the Measure. In general, we don't want to be lenient with these type of requirements. In this particular case, the improvement notation flips the meaning of the Measure. Good means bad, bad means good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #466