-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
466 bug fix for group level scoring def, and concurrent mod exception #479
Merged
JPercival
merged 1 commit into
master
from
466-care-gaps-concurrent-modification-exception
Jun 11, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
128 changes: 128 additions & 0 deletions
128
...Evaluation/resources/measure/MinimalProportionBooleanBasisSingleGroupGroupScoringDef.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| { | ||
| "id": "MinimalProportionBooleanBasisSingleGroupGroupScoringDef", | ||
| "resourceType": "Measure", | ||
| "url": "http://example.com/Measure/MinimalProportionBooleanBasisSingleGroupGroupScoringDef", | ||
| "library": [ | ||
| "http://example.com/Library/MinimalProportionBooleanBasisSingleGroup" | ||
| ], | ||
| "extension": [ { | ||
| "url": "http://hl7.org/fhir/us/cqfmeasures/StructureDefinition/cqfm-populationBasis", | ||
| "valueCode": "boolean" | ||
| } ], | ||
| "group": [ | ||
| { | ||
| "extension": [ | ||
| { | ||
| "url": "http://hl7.org/fhir/us/cqfmeasures/StructureDefinition/cqfm-scoring", | ||
| "valueCodeableConcept": { | ||
| "coding": [ | ||
| { | ||
| "system": "http://terminology.hl7.org/CodeSystem/measure-scoring", | ||
| "code": "proportion", | ||
| "display": "Proportion" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ], | ||
| "population": [ | ||
| { | ||
| "id": "initial-population", | ||
| "code": { | ||
| "coding": [ | ||
| { | ||
| "system": "http://terminology.hl7.org/CodeSystem/measure-population", | ||
| "code": "initial-population", | ||
| "display": "Initial Population" | ||
| } | ||
| ] | ||
| }, | ||
| "criteria": { | ||
| "language": "text/cql-identifier", | ||
| "expression": "Initial Population" | ||
| } | ||
| }, | ||
| { | ||
| "id": "denominator", | ||
| "code": { | ||
| "coding": [ | ||
| { | ||
| "system": "http://terminology.hl7.org/CodeSystem/measure-population", | ||
| "code": "denominator", | ||
| "display": "Denominator" | ||
| } | ||
| ] | ||
| }, | ||
| "criteria": { | ||
| "language": "text/cql-identifier", | ||
| "expression": "Denominator" | ||
| } | ||
| }, | ||
| { | ||
| "id": "denominator-exclusion", | ||
| "code": { | ||
| "coding": [ | ||
| { | ||
| "system": "http://terminology.hl7.org/CodeSystem/measure-population", | ||
| "code": "denominator-exclusion", | ||
| "display": "Denominator-Exclusion" | ||
| } | ||
| ] | ||
| }, | ||
| "criteria": { | ||
| "language": "text/cql-identifier", | ||
| "expression": "Denominator Exclusion" | ||
| } | ||
| }, | ||
| { | ||
| "id": "denominator-exception", | ||
| "code": { | ||
| "coding": [ | ||
| { | ||
| "system": "http://terminology.hl7.org/CodeSystem/measure-population", | ||
| "code": "denominator-exception", | ||
| "display": "Denominator-Exception" | ||
| } | ||
| ] | ||
| }, | ||
| "criteria": { | ||
| "language": "text/cql-identifier", | ||
| "expression": "Denominator Exception" | ||
| } | ||
| }, | ||
| { | ||
| "id": "numerator-exclusion", | ||
| "code": { | ||
| "coding": [ | ||
| { | ||
| "system": "http://terminology.hl7.org/CodeSystem/measure-population", | ||
| "code": "numerator-exclusion", | ||
| "display": "Numerator-Exclusion" | ||
| } | ||
| ] | ||
| }, | ||
| "criteria": { | ||
| "language": "text/cql-identifier", | ||
| "expression": "Numerator Exclusion" | ||
| } | ||
| }, | ||
| { | ||
| "id": "numerator", | ||
| "code": { | ||
| "coding": [ | ||
| { | ||
| "system": "http://terminology.hl7.org/CodeSystem/measure-population", | ||
| "code": "numerator", | ||
| "display": "Numerator" | ||
| } | ||
| ] | ||
| }, | ||
| "criteria": { | ||
| "language": "text/cql-identifier", | ||
| "expression": "Numerator" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
58 changes: 58 additions & 0 deletions
58
...ds/cqf/fhir/cr/measure/r4/MinimalMeasureEvaluation/tests/organization/alphora-author.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| { | ||
| "resourceType": "Organization", | ||
| "id": "alphora-author", | ||
| "meta": { | ||
| "profile": [ | ||
| "http://hl7.org/fhir/us/davinci-deqm/StructureDefinition/organization-deqm" | ||
| ] | ||
| }, | ||
| "identifier": [ | ||
| { | ||
| "system": "urn:oid:2.16.840.1.113883.4.4", | ||
| "value": "123456790", | ||
| "use": "official", | ||
| "type": { | ||
| "coding": [ | ||
| { | ||
| "code": "TAX", | ||
| "system": "http://terminology.hl7.org/CodeSystem/v2-0203", | ||
| "display": "Tax ID number" | ||
| } | ||
| ] | ||
| }, | ||
| "assigner": { | ||
| "display": "www.irs.gov" | ||
| } | ||
| } | ||
| ], | ||
| "active": true, | ||
| "type": [ | ||
| { | ||
| "coding": [ | ||
| { | ||
| "code": "prov", | ||
| "system": "http://terminology.hl7.org/CodeSystem/organization-type", | ||
| "display": "Healthcare Provider" | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "name": "Alphora", | ||
| "telecom": [ | ||
| { | ||
| "system": "phone", | ||
| "value": "(+1) 401-555-1212" | ||
| } | ||
| ], | ||
| "address": [ | ||
| { | ||
| "line": [ | ||
| "73 Lakewood Street" | ||
| ], | ||
| "city": "Warwick", | ||
| "state": "RI", | ||
| "postalCode": "02886", | ||
| "country": "USA" | ||
| } | ||
| ] | ||
| } |
58 changes: 58 additions & 0 deletions
58
...g/opencds/cqf/fhir/cr/measure/r4/MinimalMeasureEvaluation/tests/organization/alphora.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| { | ||
| "resourceType": "Organization", | ||
| "id": "alphora", | ||
| "meta": { | ||
| "profile": [ | ||
| "http://hl7.org/fhir/us/davinci-deqm/StructureDefinition/organization-deqm" | ||
| ] | ||
| }, | ||
| "identifier": [ | ||
| { | ||
| "system": "urn:oid:2.16.840.1.113883.4.4", | ||
| "value": "123456789", | ||
| "use": "official", | ||
| "type": { | ||
| "coding": [ | ||
| { | ||
| "code": "TAX", | ||
| "system": "http://terminology.hl7.org/CodeSystem/v2-0203", | ||
| "display": "Tax ID number" | ||
| } | ||
| ] | ||
| }, | ||
| "assigner": { | ||
| "display": "www.irs.gov" | ||
| } | ||
| } | ||
| ], | ||
| "active": true, | ||
| "type": [ | ||
| { | ||
| "coding": [ | ||
| { | ||
| "code": "prov", | ||
| "system": "http://terminology.hl7.org/CodeSystem/organization-type", | ||
| "display": "Healthcare Provider" | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "name": "Alphora", | ||
| "telecom": [ | ||
| { | ||
| "system": "phone", | ||
| "value": "(+1) 401-555-1212" | ||
| } | ||
| ], | ||
| "address": [ | ||
| { | ||
| "line": [ | ||
| "73 Lakewood Street" | ||
| ], | ||
| "city": "Warwick", | ||
| "state": "RI", | ||
| "postalCode": "02886", | ||
| "country": "USA" | ||
| } | ||
| ] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: This is the type of validation we should push upstream. Then we can give specific feedback in an OperationOutcome about issues with the Measure. In general, we don't want to be lenient with these type of requirements. In this particular case, the improvement notation flips the meaning of the Measure. Good means bad, bad means good.