Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packager): exit with error if config not found #195

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

lucasfernog-crabnebula
Copy link
Member

It's hard to understand you're not on the right CWD or something else is not properly set up since we're only doing a tracing::debug and exiting with code 0 (so at least you need to run with verbosity to see something). This PR changes it to an actual error.

Copy link
Contributor

@denjell-crabnebula denjell-crabnebula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice finding!

@amr-crabnebula amr-crabnebula merged commit 4c4d919 into main Apr 15, 2024
22 of 23 checks passed
@amr-crabnebula amr-crabnebula deleted the fix/error-out-if-no-config branch April 15, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants