Add glob support for icons field #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amr-crabnebula
requested changes
Dec 13, 2023
Co-authored-by: Amr Bashir <[email protected]>
|
I hope it works 🙏 |
|
Could you also add a change file |
amr-crabnebula
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works for deb. Using the helpers method, it should be easy to port this to other target. But i don't have a mac for testing, and i should be able to get a Windows in a few weeks.
I know this code is a little shitty, i'm sorry. I never used
thiserrorcrate before, so maybe it can be written with less lines.Also, i was not able to convert a glob error to the error of this crate. Maybe i missing something here. And somehow, rust-anlyzer just stop working on this project, so a little painful to debug this.