Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiverse goal validation #175

Merged

Conversation

AbdelrhmanBassiouny
Copy link
Collaborator

@AbdelrhmanBassiouny AbdelrhmanBassiouny commented Jul 31, 2024

NOTE: This pull request depends on: #189
This adds a goal validation feature for the setting of object pose and joint positions.
The use case is through the addition of the relevant decorators to the setter of the pose and joint positions.
This is now added to the abstract world and used by both bullet_world and multiverse.

Three main decorators are used:
@validate_object_pose
@validate_joint_position
@validate_multiple_joint_positions

Also contains some minor changes, cleaning, and added structures.

…ng the pose of the parent.

Also added a reset for the goal validator and the error checker.
…eaning.

set single joint position test is not passing because joints currently does not retain their positions, will be fixed soon.
…lass definition,

 and defined a new exception for unsupported joint types,
 and defined a multiverse class variable as a tuple providing the supported joint types.
… not just for multiverse.py

Added the use of validators to pybullet.
@Tigul Tigul changed the base branch from dev to multiverse-dev August 16, 2024 08:59
sunava and others added 25 commits August 17, 2024 16:42
…d spawn generic objects for example the robokudo objects
[hsrb-processmodule] introducing hsrb process module that are working…
which is more related to SOMA ontology contents themselves instead
…arsingError to not interrupt the program,

only error-log in case of loading from local iri
test_ontology: defer to loading from local iri in case of failed loading from the remote
[generic object]  for  perceiving in real world and spawn/describe obbjects from type unkown
Catch remote ontology loading error by owlready2
[robokudo interface] new queries for the newest robokudo mainly suturo
# Conflicts:
#	src/pycram/datastructures/enums.py
#	src/pycram/world_concepts/world_object.py
#	src/pycram/worlds/bullet_world.py
…verse_goal_validation

# Conflicts:
#	src/pycram/process_modules/hsrb_process_modules.py
#	src/pycram/world_concepts/world_object.py
#	src/pycram/worlds/bullet_world.py
src/pycram/datastructures/world.py Show resolved Hide resolved
src/pycram/datastructures/world.py Show resolved Hide resolved
src/pycram/datastructures/world.py Show resolved Hide resolved
src/pycram/description.py Show resolved Hide resolved
src/pycram/external_interfaces/giskard.py Show resolved Hide resolved
src/pycram/validation/goal_validator.py Show resolved Hide resolved
src/pycram/validation/goal_validator.py Show resolved Hide resolved
@Tigul Tigul merged commit 193d5ff into cram2:multiverse-dev Aug 28, 2024
@AbdelrhmanBassiouny AbdelrhmanBassiouny deleted the multiverse_goal_validation branch October 15, 2024 11:03
hawkina pushed a commit to hawkina/pycram that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants