-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiverse goal validation #175
Merged
Tigul
merged 54 commits into
cram2:multiverse-dev
from
AbdelrhmanBassiouny:multiverse_goal_validation
Aug 28, 2024
Merged
Multiverse goal validation #175
Tigul
merged 54 commits into
cram2:multiverse-dev
from
AbdelrhmanBassiouny:multiverse_goal_validation
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_value_getter_input.
…t_value_getter_input.
…aviour of bowl object.
…ng the pose of the parent. Also added a reset for the goal validator and the error checker.
…eaning. set single joint position test is not passing because joints currently does not retain their positions, will be fixed soon.
…gle responsibility.
…lass definition, and defined a new exception for unsupported joint types, and defined a multiverse class variable as a tuple providing the supported joint types.
… not just for multiverse.py Added the use of validators to pybullet.
…verse_goal_validation
… on real robot and semi real robot
…d spawn generic objects for example the robokudo objects
[hsrb-processmodule] introducing hsrb process module that are working…
which is more related to SOMA ontology contents themselves instead
…arsingError to not interrupt the program, only error-log in case of loading from local iri test_ontology: defer to loading from local iri in case of failed loading from the remote
…to if not existing) closer to code
Added turtlebot3 (waffle_pi)
[generic object] for perceiving in real world and spawn/describe obbjects from type unkown
Catch remote ontology loading error by owlready2
[robokudo interface] new queries for the newest robokudo mainly suturo
# Conflicts: # src/pycram/datastructures/enums.py # src/pycram/world_concepts/world_object.py # src/pycram/worlds/bullet_world.py
…verse_goal_validation # Conflicts: # src/pycram/process_modules/hsrb_process_modules.py # src/pycram/world_concepts/world_object.py # src/pycram/worlds/bullet_world.py
Merged
Tigul
requested changes
Aug 27, 2024
hawkina
pushed a commit
to hawkina/pycram
that referenced
this pull request
Oct 31, 2024
Knowrob binder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This pull request depends on: #189
This adds a goal validation feature for the setting of object pose and joint positions.
The use case is through the addition of the relevant decorators to the setter of the pose and joint positions.
This is now added to the abstract world and used by both bullet_world and multiverse.
Three main decorators are used:
@validate_object_pose
@validate_joint_position
@validate_multiple_joint_positions
Also contains some minor changes, cleaning, and added structures.