Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: codify subtle >=2.50 dependency #236

Closed
wants to merge 4 commits into from
Closed

Conversation

kevaundray
Copy link
Contributor

No description provided.

Cargo.lock Outdated
Comment on lines 1181 to 1185
[[package]]
name = "subtle"
version = "2.5.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "81cdd64d312baedb58e21336b31bc043b77e01cc99033ce76ef539f78e965ebc"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the lockfile, so that we can see the subtle version

@kevaundray
Copy link
Contributor Author

kevaundray commented Aug 19, 2024

Even though we have:

subtle = { version = ">=2.5.0, <3.0" }

In our Cargo.toml, doing:

 cargo update -p subtle --precise 2.4.1

Will actually downgrade subtle to 2.4.1, because it is not being used anywhere explicitly in rust-eth-kzg.

Note, that it won't build but it doesn't stop us from doing the update and getting the less helpful erorr message.

@kevaundray
Copy link
Contributor Author

The above seems to be a quirk with how workspaces work, so I'll put subtle in the bls12-381 crate only

@kevaundray
Copy link
Contributor Author

I've opened up #237 which adds subtle in the bls12-381 crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant