chore: Codify subtle version that rust-eth-kzg works with as >=2.5.0 #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as noted in #236 we need to add it into one of the packages as it will not take effect if we put it in the workspace and do not use subtle |
|
Running error: failed to select a version for the requirement `subtle = ">=2.5.0, <3.0"`
candidate versions found which didn't match: 2.4.1
location searched: crates.io index
required by package `crate_crypto_internal_eth_kzg_bls12_381 v0.4.1 (crate-crypto/peerdas-kzg/cryptography/bls12_381)`
exit 101 |
kevaundray
changed the title
|
Non-breaking since if you were using a subtle version that was less tha 2.5.0, it would not have built |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #235