Bump json5, webpack, file-loader, html-webpack-plugin, karma-webpack and style-loader #802
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
|
I've added two commits which made progress on resolving incompatibilities after updating to Webpack5, only to find out that there is no way around this error from PhantomJS 1: A similar error is outlined at ariya/phantomjs#14650, where there would have been a hope that it would work again after upgrading to a more recent version of PhantomJS:
However, it looks like further development has been suspended, see also ariya/phantomjs#15344:
On the NPM registry, the most recent release of PhantomJS is 5 years old already 23. Footnotes |
amotl
force-pushed
the
dependabot/npm_and_yarn/json5-and-webpack-and-file-loader-and-html-webpack-plugin-and-karma-webpack-and-style-loader-2.2.3
branch
from
5ca9bde
to
296131d
Compare
amotl
force-pushed
the
amo/phantomjs-to-chromium
branch
from
14bdaaf
to
4464bd1
Compare
…and style-loader Bumps [json5](https://github.com/json5/json5) to 2.2.3 and updates ancestor dependencies [json5](https://github.com/json5/json5), [webpack](https://github.com/webpack/webpack), [file-loader](https://github.com/webpack-contrib/file-loader), [html-webpack-plugin](https://github.com/jantimon/html-webpack-plugin), [karma-webpack](https://github.com/webpack-contrib/karma-webpack) and [style-loader](https://github.com/webpack-contrib/style-loader). These dependencies need to be updated together. Updates `json5` from 2.2.1 to 2.2.3 - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v2.2.1...v2.2.3) Updates `webpack` from 4.46.0 to 5.75.0 - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v4.46.0...v5.75.0) Updates `file-loader` from 1.1.11 to 6.2.0 - [Release notes](https://github.com/webpack-contrib/file-loader/releases) - [Changelog](https://github.com/webpack-contrib/file-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/file-loader@v1.1.11...v6.2.0) Updates `html-webpack-plugin` from 4.5.2 to 5.5.0 - [Release notes](https://github.com/jantimon/html-webpack-plugin/releases) - [Changelog](https://github.com/jantimon/html-webpack-plugin/blob/main/CHANGELOG.md) - [Commits](jantimon/html-webpack-plugin@v4.5.2...v5.5.0) Updates `karma-webpack` from 4.0.2 to 5.0.0 - [Release notes](https://github.com/webpack-contrib/karma-webpack/releases) - [Changelog](https://github.com/ryanclark/karma-webpack/blob/master/CHANGELOG.md) - [Commits](codymikol/karma-webpack@v4.0.2...v5.0.0) Updates `style-loader` from 0.23.1 to 3.3.1 - [Release notes](https://github.com/webpack-contrib/style-loader/releases) - [Changelog](https://github.com/webpack-contrib/style-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/style-loader@v0.23.1...v3.3.1) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect - dependency-name: webpack dependency-type: direct:development - dependency-name: file-loader dependency-type: direct:development - dependency-name: html-webpack-plugin dependency-type: direct:development - dependency-name: karma-webpack dependency-type: direct:development - dependency-name: style-loader dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
Error: Compiling RuleSet failed: Query arguments on 'loader' has been removed in favor of the 'options' property. (at ruleSet[1].rules[2].loader: url-loader?limit=10000)
amotl
force-pushed
the
dependabot/npm_and_yarn/json5-and-webpack-and-file-loader-and-html-webpack-plugin-and-karma-webpack-and-style-loader-2.2.3
branch
from
296131d
to
139f730
Compare
webpack.dev.config.js
Outdated
| @@ -77,17 +77,18 @@ module.exports = { | |||
| test: /\.(sa|sc|c)ss$/, | |||
| use: [ | |||
| { loader: 'style-loader' }, | |||
| { loader: MiniCssExtractPlugin.loader }, | |||
| { loader: MiniCssExtractPlugin.loader, options: { esModule: false } }, | |||
There was a problem hiding this comment.
Could you please explain why we need this esModule: false now?
There was a problem hiding this comment.
Hi Marios. Thank you for asking. I can barely remember it, but I think it was needed to make the code compatible with the update of corresponding components bumped here. Both 2eca85b and bef815f were needed to satisfy CI on the original patch submitted by Dependabot, the latter being responsible to update the configuration for the MiniCssExtractPlugin, which includes the spot you have been asking about.
There was a problem hiding this comment.
Maybe this quirk is no longer needed when also updating mini-css-extract-plugin to a more recent version? I will give it a try...
There was a problem hiding this comment.
Please check, the flag was set to true by default long time ago: webpack-contrib/mini-css-extract-plugin#486
There was a problem hiding this comment.
But I don't know exactly what's its purpose, if issue is still there and you think it's safe to disable it, go ahead.
There was a problem hiding this comment.
This quirk is no longer needed when also updating mini-css-extract-plugin to a more recent version.
amotl
force-pushed
the
dependabot/npm_and_yarn/json5-and-webpack-and-file-loader-and-html-webpack-plugin-and-karma-webpack-and-style-loader-2.2.3
branch
from
139f730
to
c726626
Compare
amotl
deleted the
dependabot/npm_and_yarn/json5-and-webpack-and-file-loader-and-html-webpack-plugin-and-karma-webpack-and-style-loader-2.2.3
branch
Bumps json5 to 2.2.3 and updates ancestor dependencies json5, webpack, file-loader, html-webpack-plugin, karma-webpack and style-loader. These dependencies need to be updated together.
Updates
json5from 2.2.1 to 2.2.3Release notes
Sourced from json5's releases.
Changelog
Sourced from json5's changelog.
Commits
c3a75242.2.394fd06ddocs: update CHANGELOG for v2.2.33b8cebfdocs(security): use GitHub security advisoriesf0fd9e1docs: publish a security policy6a91a05docs(template): bug -> bug report14f8cb12.2.210cc7cadocs: update CHANGELOG for v2.2.27774c10fix: add proto to objects and arraysedde30aReadme: slight tweak to intro97286f8Improve example in readmeUpdates
webpackfrom 4.46.0 to 5.75.0Release notes
Sourced from webpack's releases.
... (truncated)
Commits
8241da75.75.0a91d923Merge pull request #16458 from webpack/bugfix/semi4608b11Merge pull request #16457 from webpack/tooling/updatedfdd0b0Merge pull request #16122 from AnmolBansalDEV/bug/compilationCallback23b9a1cMerge pull request #16167 from exposir/fixts6f2c5e8Merge pull request #16257 from alexzhang1030/calc_deterministic_verbosef7f36adMerge pull request #16339 from Liamolucko/wasm-i64761a542fix semicolon position2403a36Merge pull request #16345 from ahabhgk/fix-eval-nosourcesc18203cupdate toolingUpdates
file-loaderfrom 1.1.11 to 6.2.0Release notes
Sourced from file-loader's releases.
... (truncated)
Changelog
Sourced from file-loader's changelog.
... (truncated)
Commits
c423008chore(release): 6.2.0654e0d6feat: added thesourceFilenameproperty to asset info with original filenam...381d8bdfix: immutable flag when thenameoption have hash in query string (#392)14ed4c9ci: updated webpack versions (#389)6fadfbechore(release): 6.1.160508cfchore(deps): update25e2668chore(release): 6.1.06e22f6etest: fix40fcde8feat: pass immutable flag to asset info (#383)718aef5chore(deps): update (#375)Maintainer changes
This version was pushed to npm by evilebottnawi, a new releaser for file-loader since your current version.
Updates
html-webpack-pluginfrom 4.5.2 to 5.5.0Changelog
Sourced from html-webpack-plugin's changelog.
... (truncated)
Commits
873d75bchore(release): 5.5.0ddeb774chore: update examples1e42625feat: Support type=module via scriptLoading option7d3645bBump pretty-error to 4.0.0 to fix transitive vuln for ansi-regex CVE-2021-380779be779[chore] changes actions to run on pull_requestsb7e5859[chore] fixes CI to avoid race conditions48131d3chore(release): 5.4.016a841a[chore] rebuild examples3bb7c17Update index.jse38ac97Update index.jsUpdates
karma-webpackfrom 4.0.2 to 5.0.0Release notes
Sourced from karma-webpack's releases.
Changelog
Sourced from karma-webpack's changelog.
... (truncated)
Commits
e2423b4chore: release v5.0.046a5505Merge branch 'master' into next71fc63afix(config): ignore entry options (#479)05cfa79fix(docs): fixed warning inaccuracy (#478)1598fa6fix(config): force default output.filename (#477)d603679change(readme): made minor adjustments (#476)5300200refactor(*): break up into individual modules (#474)8ad09d1fix(test): handle scenario test rejection (#473)da86766chore(release): 5.0.0-alpha.698b3ec9chore(deps): bump hotfix dependencies (#472)Maintainer changes
This version was pushed to npm by ryanclark, a new releaser for karma-webpack since your current version.
Updates
style-loaderfrom 0.23.1 to 3.3.1Release notes
Sourced from style-loader's releases.
... (truncated)
Changelog
Sourced from style-loader's changelog.
... (truncated)
Commits
4663416chore(release): 3.3.1610524efix: small perf improvement (#544)c799eccchore(release): 3.3.0b47718atest: update (#542)43bede4refactor: code (#541)b9a600cfeat: added support for@supports,@layerand@mediafrom@importat-...74fa1cfchore(deps): update (#539)cdf0ba7refactor: codecaf66a0chore(deps): updatef8ef63bfeat: allow to pass options toinsertfunction throughstyle.use()(#535)Maintainer changes
This version was pushed to npm by evilebottnawi, a new releaser for style-loader since your current version.
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.