-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Satisfy testing on macOS #386
Conversation
f32c5e4
to
2eac877
Compare
It looks like GHA is currently not able to access
[1] https://github.com/crate/crate-python/pull/386/checks?check_run_id=1322270579 |
Downloading the release tarballs started working again. Now the
So, #384 will hopefully heal that? [1] https://github.com/crate/crate-python/pull/386/checks?check_run_id=1322310763 |
After re-running the tests, they apparently succeeded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also add windows and macos to the build matrix in the github actions config?
2eac877
to
a012ece
Compare
That would be nice, right? |
a012ece
to
e03aed6
Compare
40b21b5
to
2f406a8
Compare
d00f767
to
cd47834
Compare
I just added Because I have not been able to adjust the test matrix appropriately to run CrateDB nightly on |
d5f27e7
to
c6710c2
Compare
06d25f3
to
b138f82
Compare
Having it included, it would need maintenance on the branch protection page each time we bump the CrateDB version.
About
This is somehow related to crate/crash#343, it makes the test suite work on macOS.
On top of using conditional buildout configuration sections for pulling down the appropriate CrateDB distribution tarballs for other operating systems than Linux,
it skips some tests currently not working on macOS. Windows support has not been verified yet, I am working on this on behalf of #388.Summary of the changes
CrateLayer.from_uri
as it does not honor the platform when building the download URL. Instead, re-add it as a unit tests which at least runs the function by mocking_download_and_extract
into a noop.ubuntu-latest
) and multi-platform tests against a specific version of CrateDB (run on bothubuntu-latest
andmacos-latest
).REFRESH TABLE
appropriately.