-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Job io extra 2 #221
Merged
Merged
Job io extra 2 #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmigneault
added
WIP
Work in progress
triage/conformance
Issue related to fixing/ensuring compliance to specifications.
feature/job
Issues related to job execution, reporting and logging.
labels
Feb 26, 2021
…amples in docstring
…pattern according to requirements
…her webtest-testapp
fmigneault
added
ci/doc
Issue related to documentation of the package
ci/tests
Tests of the package and features
feature/oas
Issues related to OpenAPI specifications.
project/OGC
Related to OGC testbeds or relavant projects.
triage/enhancement
New feature or request
and removed
WIP
Work in progress
labels
Mar 13, 2021
dbyrns
approved these changes
Mar 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great conformance job! Just be careful with feature creep (Windows support, requests caching)
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/doc
Issue related to documentation of the package
ci/tests
Tests of the package and features
feature/job
Issues related to job execution, reporting and logging.
feature/oas
Issues related to OpenAPI specifications.
project/OGC
Related to OGC testbeds or relavant projects.
triage/conformance
Issue related to fixing/ensuring compliance to specifications.
triage/enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Recent version
2.x
fixes brought back into branch job-io-extras and completed to make all tests pass.Changes
jobs/{id}/result
is deprecated but redirects tojobs/{id}/outputs
which as similar format (but with extralinks
references)jobs/{id}/results
follows the official output format of OGC-API schemascornice_swagger
&colander
generatorsoneOf
,allOf
, etc. keywordsvs "old" one: https://pavics-weaver.readthedocs.io/en/2.2.0/api.html
notable differences in Deploy body for example.
(eg
field x is invalid because ... expected ...
)with deeply nested parsing (as far as provided by schemas)
Examples
Detailed schema definitions (before vs after) :
Invalid schema validation error message
Specific error raised details which field, index, value, etc. cause the error and everything that was evaluated against valid schemas.
Error is both logged and reported in corresponding request response.
In this case, invalid value
random
was placed astype
for the one of the CWL package inputs.Documented deprecation / changes