Fragments

[librasteve]

This request is an implementation of Fragments for the Cro Template language.

It addresses this Feature Request Issue #90 which hopefully provides a rationale for the new feature.

I will shortly make a PR for cro-website to update the docs to include the new feature.

I suggest a point bump in the major version since this extends the API, e.g. to 0.9.0 which I leave to the person merging this PR if it is approved.

[patrickbkr]

Thanks for putting work into this. This is looking promising. I'll give this a review as soon as I find some time.

[patrickbkr]

All in all looking good. Just some polishing is missing.

[librasteve]

Good catches in there - thanks!

Hopefully all is now shiny.

I will now go change § to ~ in the docs ;-)

[patrickbkr]

@librasteve: Are you aware that the Cro project is currently severely lacking maintainers? Currently I and pe_elle (who only recently joined) are the only ones doing maintainer work (currently reviewing is what's needed the most). Given there is a policy of one-review-before-merge, my own PRs are currently effectively frozen because I can't review my own PRs. Would you consider joining the team? It does seem like you know the stack.

[librasteve]

yes - I would be very happy to join the team - thank you for the invitation

[patrickbkr]

I've just sent you an invite. How can you be reached? I guess this github issue is not the best communication platform. :-)

[patrickbkr]

Looking good!

[patrickbkr]

Are you OK with merging this as well now?

[librasteve]

my email is [email protected], also Discord is good

[librasteve]

OK - I gather that CI was failing before my PR

[librasteve]

Yes, I am happy to proceed with the merge (GH is not giving me a Merge button, so I guess you will have to press the button please)

[patrickbkr]

Yeah, I know what's wrong with the CI. Fix is upcoming.