fix: "None" in key path when no prefix is specified #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you didn't specify
prefix
config you would end up with a file path containingNone
or duplicate forward slashes if set to an empty string
both of which result in an undesirable structure in S3:
This change handles
prefix
optionally for the key, usingpathlib
to normalise the path.A similar issue was resolved where the file name stem in the generated key path ended with a slash (as above) when disabling some of the
append_
settings:Fixes #19