Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: abstract EventLoop::Polling#system_add invalid signature #15358

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

straight-shoota
Copy link
Member

Resolves #15357

@straight-shoota straight-shoota added topic:stdlib:runtime kind:regression Something that used to correctly work but no longer works labels Jan 20, 2025
@straight-shoota straight-shoota self-assigned this Jan 20, 2025
@ysbaddaden ysbaddaden changed the title Fix path in abstract def type restriction Fix: abstract EventLoop::Polling#system_add invalid signature Jan 21, 2025
@ysbaddaden
Copy link
Contributor

Oh my 🤦

@ysbaddaden ysbaddaden added this to the 1.15.1 milestone Jan 21, 2025
@ysbaddaden ysbaddaden merged commit 5a245d9 into crystal-lang:master Jan 21, 2025
70 checks passed
@straight-shoota straight-shoota deleted the fix/polling-index branch January 21, 2025 08:26
Copy link
Contributor

Successfully created backport PR for release/1.15:

@straight-shoota straight-shoota added the kind:bug A bug in the code. Does not apply to documentation, specs, etc. label Feb 3, 2025
@crysbot
Copy link
Collaborator

crysbot commented Feb 3, 2025

Backport failed for release/1.15, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/1.15
git worktree add -d .worktree/backport-15358-to-release/1.15 origin/release/1.15
cd .worktree/backport-15358-to-release/1.15
git switch --create backport-15358-to-release/1.15
git cherry-pick -x 5a245d905717ff9ea8a62512d8a5e0fefa721959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/1.15 kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works topic:stdlib:runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crystal 1.15 seems to have symbol Index reserved
3 participants