Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release/1.15] Fix: abstract EventLoop::Polling#system_add invalid signature #15380

Merged
merged 1 commit into from
Jan 28, 2025
Merged

[Backport release/1.15] Fix: abstract EventLoop::Polling#system_add invalid signature #15380

merged 1 commit into from
Jan 28, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Automated backport of #15358 to release/1.15, triggered by a label.

@straight-shoota @github-actions
Fix: abstract EventLoop::Polling#system_add invalid signature
53a1e5b 
The abstract method refers to the non existing `Index` type. Weirdly the compiler won't complain until someone defines an `Index` type.

Resolves #15357

(cherry picked from commit 5a245d9)
@github-actions github-actions bot added this to the 1.15.1 milestone Jan 27, 2025
@github-actions github-actions bot added kind:regression Something that used to correctly work but no longer works topic:stdlib:runtime labels Jan 27, 2025
@github-actions github-actions bot mentioned this pull request Jan 27, 2025
Merged
@Blacksmoke16
Copy link
Member

Neat, this is pretty slick.

@straight-shoota straight-shoota merged commit ea98639 into release/1.15 Jan 28, 2025
@straight-shoota straight-shoota deleted the backport-15358-to-release/1.15 branch January 28, 2025 19:21
@straight-shoota straight-shoota added the kind:bug A bug in the code. Does not apply to documentation, specs, etc. label Feb 3, 2025
@BrewTestBot BrewTestBot mentioned this pull request Feb 4, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysbaddaden ysbaddaden ysbaddaden approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works topic:stdlib:runtime
Projects
None yet
Milestone
1.15.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Blacksmoke16 @ysbaddaden @straight-shoota