ci: re-enable testing on Windows with Python 3.12 #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xalpharush
reviewed
Jan 11, 2024
| python_requires=">=3.8", | ||
| # Python 3.12.0 on Windows suffers from https://github.com/python/cpython/issues/109590 | ||
| # breaking some of our integrations. The issue is fixed in 3.12.1 | ||
| python_requires=">=3.8,!=3.12.0", |
There was a problem hiding this comment.
Should we treat this as breaking?
There was a problem hiding this comment.
we can drop this restriction if you feel it's too much. I tried looking to see if there was a way to specify the version exception just for Windows but did not find anything suitable.
There was a problem hiding this comment.
AFAICT pip should handle this and not leave anyone using python3.12.0 and crytic-compile with a broken build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.12.0 on Windows suffers from python/cpython#109590 breaking some of our integrations. The issue is fixed in 3.12.1