Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: re-enable testing on Windows with Python 3.12 #535

Merged
merged 2 commits into from
Jan 16, 2024
Merged

ci: re-enable testing on Windows with Python 3.12 #535

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
234be4f
ci: re-enable testing on Windows with Python 3.12
elopez Jan 11, 2024
983e2b5
Merge branch 'dev' into fix/windows-3.12-npx
0xalpharush Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ jobs:
# brownie does not install correctly with Python 3.12
- python: 3.12
type: brownie
# TODO: review failure executing npx on Windows
- os: windows-2022
python: 3.12
steps:
- uses: actions/checkout@v4
- name: Set up shell
Expand Down
4 changes: 3 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@
author="Trail of Bits",
version="0.3.4",
packages=find_packages(),
python_requires=">=3.8",
# Python 3.12.0 on Windows suffers from https://github.com/python/cpython/issues/109590
# breaking some of our integrations. The issue is fixed in 3.12.1
python_requires=">=3.8,!=3.12.0",
Copy link
Contributor

@0xalpharush 0xalpharush Jan 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we treat this as breaking?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can drop this restriction if you feel it's too much. I tried looking to see if there was a way to specify the version exception just for Windows but did not find anything suitable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT pip should handle this and not leave anyone using python3.12.0 and crytic-compile with a broken build

install_requires=["pycryptodome>=3.4.6", "cbor2", "solc-select>=v1.0.4", "toml>=0.10.2"],
extras_require={
"test": [
Expand Down