-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to get point on shower axis in altaz #2537
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
4acd495
to
02e3e25
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Can you show an example with larger images?
This is at the moment relatively slow (using this for Algorithm 6 of the reconstruction comparison paper takes around 400 ms per event) but most time is spent in astropy coordinate transformations, which is directly affected by a patch made to improve performance there in the next astropy release. |
Thanks, the lower-E one was not so convincing because the pixelation on small images makes the effect of a misalignment, but this one looks very convincing. |
eed4ce5
to
b17dd06
Compare
This comment has been minimized.
This comment has been minimized.
Analysis Details0 IssuesCoverage and DuplicationsProject ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs |
This can be used to compute the shower axis in telescope / camera frame, e.g. like this: