Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to get point on shower axis in altaz #2537

Merged
merged 8 commits into from
Apr 24, 2024
Merged

Add function to get point on shower axis in altaz #2537

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d9c3a02
Improve docstring
maxnoe Apr 22, 2024
7c29411
Add function to get points on shower axis in altaz
maxnoe Apr 22, 2024
ed9042c
Optimize, use existing faster function
maxnoe Apr 22, 2024
4de96ea
Add simple tests for get_point_on_shower_axis
maxnoe Apr 22, 2024
cd401d5
Add changelog entry
maxnoe Apr 22, 2024
90b7cd8
Add distance argument to altaz_to_right_handed_cartesian
maxnoe Apr 22, 2024
b17dd06
Fix docstring
maxnoe Apr 22, 2024
d77e136
Fix typo
maxnoe Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ctapipe/coordinates/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,13 @@ def get_point_on_shower_axis(core_x, core_y, alt, az, telescope_position, distan
Azimuth of primary
telescope_position : GroundFrame
Telescope position
slant_distance : u.Quantity[length]
distance : u.Quantity[length]
Distance from along the shower axis from the ground of the point returned.
maxnoe marked this conversation as resolved.
Show resolved Hide resolved

Returns
-------
coord : AltAz
The AltAz coordinate of a point on the shower axis at distance `slant_distance`
The AltAz coordinate of a point on the shower axis at the given distance
from the impact point.
"""
impact = u.Quantity([core_x, core_y, _zero_m], unit=u.m)
Expand Down