Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: consolidate marketing site, hacker portal app, and docs site into monorepo #60

Merged
merged 39 commits into from
Aug 16, 2024
Merged

chore!: consolidate marketing site, hacker portal app, and docs site into monorepo #60

merged 39 commits into from
Aug 16, 2024

Conversation

MFarabi619
Copy link
Member

@MFarabi619 MFarabi619 commented Aug 13, 2024 •
edited by JeremyFriesenGitHub
Loading

All our code has been consolidated into an Nx monorepo. The migration is still in progress as the Nx task inference for the landing page, and portal are not yet working. This is okay, as it's not a gating issue and will be resolved soon.

You can see the new architecture without having to clone my branch here

image

The existing configurations need to be factored out into the base configs. The landing-page will become website, and the hackathon should be moved over to portal. The docs site should also get its own docs directory eventually.

You can continue working as usual by just navigating into the directories first.

cd apps/hackathon
pnpm i
pnpm dev

cd apps/landing-page
pnpm i
pnpm dev

Once the migration is complete, you no longer have to do this.

TODO:
Set up the following,

  • Husky
  • Commitizen
  • Commitlint

Semantic release is no longer necessary as Nx is capable of versioning and releasing changelogs.

  • Archive landing-page and move deployment. Remove the application form too.
  • Rename hackathon repo to 2025

README has been given a full makeover:
image

@MFarabi619 MFarabi619 linked an issue Aug 13, 2024 that may be closed by this pull request
[ADR] Consolidate Marketing site, Hacker Portal App, and Docs site into Monorepo #40
Closed
@netlify Netlify
Copy link

netlify bot commented Aug 13, 2024 •
edited
Loading

❌ Deploy Preview for cuhacking-portal-test-deployment failed. Why did it fail? →

Name Link
🔨 Latest commit 7cc159c
🔍 Latest deploy log https://app.netlify.com/sites/cuhacking-portal-test-deployment/deploys/66be96f5a1b3d600087d4bc8

@MFarabi619 MFarabi619 added the enhancement New feature or request label Aug 13, 2024
@MFarabi619 MFarabi619 force-pushed the mfarabi/chore/40-consolidate-marketing-site-hacker-portal-app-and-docs-site-into-monorepo branch 2 times, most recently from 045343d to 78b9153 Compare August 13, 2024 18:15
@HasithDeAlwis
Copy link
Collaborator

Really cool work, excited to get this merged in. Do you think you can explain what the portal directory is?

@MFarabi619
Copy link
Member Author

Really cool work, excited to get this merged in. Do you think you can explain what the portal directory is?

image

In a nutshell hackathon is getting re-named to portal.

@MFarabi619 MFarabi619 changed the title chore: consolidate marketing site, hacker portal app, and docs site into monorepo chore!: consolidate marketing site, hacker portal app, and docs site into monorepo Aug 14, 2024
@MFarabi619 MFarabi619 force-pushed the mfarabi/chore/40-consolidate-marketing-site-hacker-portal-app-and-docs-site-into-monorepo branch from 4df0539 to dbf8626 Compare August 15, 2024 01:36
@MFarabi619 MFarabi619 force-pushed the mfarabi/chore/40-consolidate-marketing-site-hacker-portal-app-and-docs-site-into-monorepo branch from dbf8626 to 5a16604 Compare August 15, 2024 01:41
@MFarabi619
docs(tools-overview): add nx
e81aae0
@MFarabi619
chore: copy landing page into apps directory
880aaa1
@MFarabi619
docs(contribution-guidelines): add callout for monorepo migration
c191fe8
@MFarabi619
docs(conventional-commits): update commit scope specifications and ad…
417dcd3 
…d examples
@MFarabi619
chore(config/package.json): add repository key with url
e5ed88e
@MFarabi619
chore(config/prettierignore): add node_modules
c2e4b34
@MFarabi619
style(base/config/tsconfig): improve readability using capital letter…
b2356fa 
…s on values
@MFarabi619
chore(base/config/tsconfig): add properties
41a55aa
@MFarabi619
chore(base/config/vscode): add settings.json
b721d90
@MFarabi619
chore(portal/docs): complete migration of docs site
38cdaf2
@MFarabi619
fix(ui/docs): gap between sidebar and header
c0fed4f
@MFarabi619
docs(system-requirements): add tip to install homebrew in wsl to get …
96220a1 
…latest packages
@MFarabi619
fix(docs/layout): landing page source link going to website instead o…
947fde7 
…f github repo
@MFarabi619 MFarabi619 force-pushed the mfarabi/chore/40-consolidate-marketing-site-hacker-portal-app-and-docs-site-into-monorepo branch from 5a16604 to fdb5c3b Compare August 15, 2024 04:49
@MFarabi619 MFarabi619 force-pushed the mfarabi/chore/40-consolidate-marketing-site-hacker-portal-app-and-docs-site-into-monorepo branch from d12fe41 to 603e7ec Compare August 15, 2024 05:48
@MFarabi619 MFarabi619 mentioned this pull request Aug 15, 2024
Closed
@MFarabi619 MFarabi619 force-pushed the mfarabi/chore/40-consolidate-marketing-site-hacker-portal-app-and-docs-site-into-monorepo branch from 945a621 to 7cc159c Compare August 16, 2024 00:01
@MFarabi619 MFarabi619 marked this pull request as ready for review August 16, 2024 00:02
HasithDeAlwis
HasithDeAlwis approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@HasithDeAlwis HasithDeAlwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@MFarabi619 MFarabi619 enabled auto-merge (rebase) August 16, 2024 00:05
cloverzer0
cloverzer0 approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@cloverzer0 cloverzer0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@MFarabi619 MFarabi619 merged commit 7c72db7 into main Aug 16, 2024
0 of 8 checks passed
@MFarabi619 MFarabi619 mentioned this pull request Aug 20, 2024
Merged
@HasithDeAlwis HasithDeAlwis mentioned this pull request Sep 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloverzer0 cloverzer0 cloverzer0 approved these changes

@HasithDeAlwis HasithDeAlwis HasithDeAlwis approved these changes

@JowiAoun JowiAoun Awaiting requested review from JowiAoun

@Aashna-Verma Aashna-Verma Awaiting requested review from Aashna-Verma

@Isabella-Nguyen Isabella-Nguyen Awaiting requested review from Isabella-Nguyen

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADR] Consolidate Marketing site, Hacker Portal App, and Docs site into Monorepo
3 participants
@MFarabi619 @HasithDeAlwis @cloverzer0