Tabs state colours to reflect designs #5509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0cd7c75 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ryanseddon
reviewed
Feb 11, 2025
| @@ -23,7 +23,6 @@ | |||
| } | |||
|
|
|||
| &:focus-visible { | |||
| background: var(--color-blue-100); | |||
There was a problem hiding this comment.
If I'm interpreting the jira screenshot correctly focused should still have the blue background?
There was a problem hiding this comment.
There were a few differences between the jira screenshot and the Figma branch that Jess was working on -> I'm going off this figma design
ryanseddon
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://cultureamp.atlassian.net/browse/KZN-2922
Updates colours to reflect design changes to Tabs inline with the button
What