Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs state colours to reflect designs #5509

Merged
merged 6 commits into from
Feb 11, 2025
+21 −6
Merged

Tabs state colours to reflect designs #5509

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bdc040c
updates colors to reflect design changes
Kitty-Al Feb 7, 2025
fa9af58
Tabs active background colour change
Kitty-Al Feb 7, 2025
912c973
Merge branch 'main' into KZN-2922/tab-interaction-states
Kitty-Al Feb 10, 2025
6121138
Merge branch 'main' into KZN-2922/tab-interaction-states
Kitty-Al Feb 10, 2025
290c0fb
Merge branch 'main' into KZN-2922/tab-interaction-states
Kitty-Al Feb 11, 2025
0cd7c75
Merge branch 'main' into KZN-2922/tab-interaction-states
Kitty-Al Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tiny-elephants-kick.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@kaizen/components': patch
---

Tabs: small style changes in line with button
7 changes: 5 additions & 2 deletions packages/components/src/__rc__/Tabs/subcomponents/Tab/Tab.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
}

&:focus-visible {
background: var(--color-blue-100);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm interpreting the jira screenshot correctly focused should still have the blue background?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a few differences between the jira screenshot and the Figma branch that Jess was working on -> I'm going off this figma design

color: var(--color-blue-500);
border-color: var(--color-blue-500);
}
Expand All @@ -37,9 +36,13 @@
}

&:not([data-disabled]):hover {
background: var(--color-blue-100);
background: var(--color-blue-200);
color: var(--color-blue-500);
}

&:not([data-disabled]):active {
background: var(--color-blue-100);
}
}

.tab[data-selected] {
Expand Down
15 changes: 11 additions & 4 deletions packages/components/src/__rc__/Tabs/subcomponents/TabList/TabList.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
}

.tabList {
border-bottom: 1px solid rgba(var(--color-gray-600-rgb), 0.1);
border-bottom: 1px solid var(--color-gray-300);
padding: var(--spacing-6) 0 0;
width: 100%;
height: 100%;
Expand Down Expand Up @@ -42,7 +42,7 @@

.leftArrow,
.leftArrow:hover {
border-right: 1px solid rgba(var(--color-gray-600-rgb), 0.1);
border-right: 1px solid var(--color-gray-300);
}

.rightArrow {
Expand All @@ -51,10 +51,17 @@

.rightArrow,
.rightArrow:hover {
border-left: 1px solid rgba(var(--color-gray-600-rgb), 0.1);
border-left: 1px solid var(--color-gray-300);
}

.leftArrow:hover,
.rightArrow:hover {
background: var(--color-gray-200);
background: var(--color-blue-200);
color: var(--color-blue-500);
}

.leftArrow:active,
.rightArrow:active {
background: var(--color-blue-100);
color: var(--color-blue-500);
}