chore: Create internal settings screen #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## update-settings-page-ux #452 +/- ##
==========================================================
Coverage ? 51.21%
Complexity ? 287
==========================================================
Files ? 95
Lines ? 2269
Branches ? 353
==========================================================
Hits ? 1162
Misses ? 1007
Partials ? 100 ☔ View full report in Codecov by Sentry. |
|
Build available to test |
📏 SDK Binary Size Comparison ReportNo changes detected in SDK binary size ✅ |
mahmoud-elmorabea
changed the title
This was referenced Oct 10, 2024
mahmoud-elmorabea
merged commit ffa1f75
into
update-settings-page-ux
38 of 40 checks passed
mahmoud-elmorabea
added a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one of series of PRs that update the UX of the settings page for the Java_Layout sample app.
PR stack:
Notes:
update-settings-page-uxand then merge them as onechoreto the main branchchorenot to trigger an SDK release when this is mergedThe general idea of the improvements is to have our settings screen map as close as possible to the configuration of our SDK when it's being initialized. You can see how closely the fields in this internal settings screen map to the config:
The UI was tested on multiple devices
Video of how it works
internal-settings-vid.webm