chore: Update sample app theme to new brand #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## update-settings-page-ux #454 +/- ##
==========================================================
Coverage ? 51.21%
Complexity ? 287
==========================================================
Files ? 95
Lines ? 2269
Branches ? 353
==========================================================
Hits ? 1162
Misses ? 1007
Partials ? 100 ☔ View full report in Codecov by Sentry. |
|
Build available to test |
📏 SDK Binary Size Comparison ReportNo changes detected in SDK binary size ✅ |
mahmoud-elmorabea
force-pushed
the
update-public-settings-screen
branch
from
97bf238 to
8f5d2ac
Compare
mahmoud-elmorabea
force-pushed
the
update-native-sample-app-theme
branch
2 times, most recently
from
a56f486 to
fd4a491
Compare
mrehan27
approved these changes
Oct 16, 2024
Base automatically changed from
update-public-settings-screen
to
update-settings-page-ux
October 16, 2024 14:10
mahmoud-elmorabea
force-pushed
the
update-native-sample-app-theme
branch
from
fd4a491 to
977552f
Compare
mahmoud-elmorabea
merged commit bfe818b
into
update-settings-page-ux
33 of 35 checks passed
mahmoud-elmorabea
added a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one of series of PRs that update the UX of the settings page for the Java_Layout sample app.
PR stack:
Notes:
update-settings-page-uxand then merge them as onechoreto the main branchchorenot to trigger an SDK release when this is mergedScreenshots