feat: support for large in-app messages #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
============================================
+ Coverage 41.98% 51.78% +9.79%
- Complexity 259 290 +31
============================================
Files 99 96 -3
Lines 2320 2584 +264
Branches 344 355 +11
============================================
+ Hits 974 1338 +364
+ Misses 1247 1138 -109
- Partials 99 108 +9 ☔ View full report in Codecov by Sentry. |
|
Build available to test |
📏 SDK Binary Size Comparison ReportNo changes detected in SDK binary size ✅ |
mrehan27
approved these changes
Oct 24, 2024
messaginginapp/src/main/java/io/customer/messaginginapp/gist/GistEnvironment.kt
Outdated
Show resolved
Hide resolved
messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/GistView.kt
Show resolved
Hide resolved
...ginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
Show resolved
Hide resolved
stephen-pope-customer-io
approved these changes
Oct 25, 2024
|
|
|
|
github-actions bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
## [4.4.0](4.3.0...4.4.0) (2024-11-13) ### Features * support for large in-app messages ([#456](#456)) ([b8331bf](b8331bf))
BernardGatt
reviewed
Nov 28, 2024
|
|
||
| it.webViewClient = object : WebViewClient() { | ||
| override fun onPageFinished(view: WebView, url: String?) { | ||
| view.loadUrl("javascript:window.parent.postMessage = function(message) {window.${EngineWebViewInterface.JAVASCRIPT_INTERFACE_NAME}.postMessage(JSON.stringify(message))}") |
There was a problem hiding this comment.
I think this is what's breaking the bridge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: MBL-547: Bug: Large in-app messages not getting delivered
changes:
shownMessageQueueIdsonly after dismissal, aligning with how we handle in-app message viewed logs in our middleware today