Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for large in-app messages #456
feat: support for large in-app messages #456
Changes from 4 commits
308d441
f6289ef
c35c817
b5db9da
3208711
817ef67
f00844c
fb1fa71
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 13 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/GistEnvironment.kt
Codecov / codecov/patch
messaginginapp/src/main/java/io/customer/messaginginapp/gist/GistEnvironment.kt#L13
Check warning on line 55 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/GistView.kt
GitHub Actions / API check
Check warning on line 55 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/GistView.kt
GitHub Actions / Android Lint (messaginginapp)
Check warning on line 55 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/GistView.kt
GitHub Actions / API check
Check warning on line 55 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/GistView.kt
GitHub Actions / Android Lint (messaginginapp)
Check warning on line 55 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/GistView.kt
GitHub Actions / Unit tests (messaginginapp)
Check warning on line 55 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/GistView.kt
GitHub Actions / Snapshot build and publish
Check warning on line 55 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/GistView.kt
GitHub Actions / Generate Comparison Report
Check warning on line 55 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/GistView.kt
GitHub Actions / Generate Comparison Report
Check warning on line 128 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/GistView.kt
Codecov / codecov/patch
messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/GistView.kt#L128
Check warning on line 83 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
Codecov / codecov/patch
messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt#L78-L83
Check warning on line 90 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
Codecov / codecov/patch
messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt#L85-L90
Check warning on line 95 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
Codecov / codecov/patch
messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt#L93-L95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is what's breaking the bridge
Check warning on line 97 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
Codecov / codecov/patch
messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt#L97
Check warning on line 103 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
Codecov / codecov/patch
messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt#L99-L103
Check warning on line 105 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
GitHub Actions / Generate Comparison Report
Check warning on line 105 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
Codecov / codecov/patch
messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt#L105
Check warning on line 107 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
GitHub Actions / API check
Check warning on line 107 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
GitHub Actions / Android Lint (messaginginapp)
Check warning on line 107 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
GitHub Actions / API check
Check warning on line 107 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
GitHub Actions / Android Lint (messaginginapp)
Check warning on line 107 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
GitHub Actions / Unit tests (messaginginapp)
Check warning on line 107 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
GitHub Actions / Snapshot build and publish
Check warning on line 107 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
GitHub Actions / Generate Comparison Report
Check warning on line 109 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
GitHub Actions / Generate Comparison Report
Check warning on line 111 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
GitHub Actions / API check
Check warning on line 111 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
GitHub Actions / Android Lint (messaginginapp)
Check warning on line 111 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
GitHub Actions / API check
Check warning on line 111 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
GitHub Actions / Android Lint (messaginginapp)
Check warning on line 111 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
GitHub Actions / Unit tests (messaginginapp)
Check warning on line 111 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
GitHub Actions / Snapshot build and publish
Check warning on line 111 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
GitHub Actions / Generate Comparison Report
Check warning on line 118 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
Codecov / codecov/patch
messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt#L118
Check warning on line 126 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
Codecov / codecov/patch
messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt#L126
Check warning on line 134 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
Codecov / codecov/patch
messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt#L134
Check warning on line 145 in messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt
Codecov / codecov/patch
messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/engine/EngineWebView.kt#L145
Check warning on line 24 in messaginginapp/src/main/java/io/customer/messaginginapp/state/InAppMessageReducer.kt
Codecov / codecov/patch
messaginginapp/src/main/java/io/customer/messaginginapp/state/InAppMessageReducer.kt#L24
Check warning on line 40 in messaginginapp/src/main/java/io/customer/messaginginapp/state/InAppMessageReducer.kt
Codecov / codecov/patch
messaginginapp/src/main/java/io/customer/messaginginapp/state/InAppMessageReducer.kt#L39-L40
Check warning on line 51 in messaginginapp/src/main/java/io/customer/messaginginapp/state/InAppMessagingMiddlewares.kt
Codecov / codecov/patch
messaginginapp/src/main/java/io/customer/messaginginapp/state/InAppMessagingMiddlewares.kt#L50-L51
Check warning on line 64 in messaginginapp/src/main/java/io/customer/messaginginapp/state/InAppMessagingMiddlewares.kt
Codecov / codecov/patch
messaginginapp/src/main/java/io/customer/messaginginapp/state/InAppMessagingMiddlewares.kt#L64