Skip to content

Basic Virtual Memory Implementation Fixes & Improvements #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Basic Virtual Memory Implementation Fixes & Improvements #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7bc6c89
Machine: store current privilege level in CoreState
nemecad Sep 3, 2025
3ca6851
Machine: add supervisor CSRs and sstatus handling
nemecad Sep 3, 2025
5facd54
Machine: add TLB with policies and add SV32 page-table walker
nemecad Sep 3, 2025
495a543
Tests: add SV32 page-table + TLB integration tests
nemecad Sep 3, 2025
3b888b1
GUI: show current privilege level in core state view
nemecad Sep 3, 2025
fe46efc
GUI: add virtual memory configuration to NewDialog
nemecad Sep 3, 2025
5f4fb50
GUI: add TLB visualization and statistics dock
nemecad Sep 3, 2025
e89eb87
GUI: add "As CPU (VMA)" memory access view
nemecad Sep 3, 2025
59110d9
GUI: fix zoom scaling issue
nemecad Oct 5, 2025
a63b8c1
Machine: eliminate data duplication for privilege state
nemecad Oct 5, 2025
48f2cfb
Machine: refactor TLB setup
nemecad Oct 5, 2025
ca4300b
Tests: update stalls test expected output
nemecad Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion extras/core_graphics/diagram.drawio
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<mxGeometry relative="1" as="geometry">
<mxPoint x="232" y="258" as="targetPoint" />
<Array as="points">
<mxPoint x="301" y="266" t />
<mxPoint x="301" y="266" />
<mxPoint x="301" y="258" />
</Array>
</mxGeometry>
Expand Down Expand Up @@ -968,6 +968,16 @@
<mxGeometry x="37" width="40" height="10" as="geometry" />
</mxCell>
</object>
<UserObject label="Privilege:" tags="simple pipeline forwarding" id="Haz_PrivilegeLabel">
<mxCell style="text;strokeColor=none;fillColor=none;align=center;verticalAlign=middle;rounded=0;fontSize=6;fontFamily=sans-serif;fontStyle=1;spacing=0;labelPosition=center;verticalLabelPosition=middle;labelBackgroundColor=none;spacingBottom=1;" parent="i2To6XwWsyNyerFe5G8K-6" vertex="1">
<mxGeometry x="2" y="30" width="41" height="8" as="geometry" />
</mxCell>
</UserObject>
<object label="MACHINE" component="multi-text-value" source="Privilege" tags="simple hazardunit pipeline forwarding" id="uWEq7-PrivilegeValue">
<mxCell style="text;strokeColor=none;fillColor=none;align=left;verticalAlign=middle;rounded=0;fontFamily=sans-serif;fontSize=9;fontColor=#000000;fontStyle=1;spacing=0;spacingBottom=1;" parent="i2To6XwWsyNyerFe5G8K-6" vertex="1">
<mxGeometry x="37" y="27" width="40" height="10" as="geometry" />
</mxCell>
</object>
<object label="0" component="debug-value" source="StallCount" tags="simple hazardunit pipeline forwarding" id="uWEq7-W_z53UrtFael4O-79">
<mxCell style="text;strokeColor=none;fillColor=none;align=left;verticalAlign=middle;rounded=0;fontFamily=sans-serif;fontSize=9;fontColor=#000000;fontStyle=1;spacing=0;spacingBottom=1;" parent="i2To6XwWsyNyerFe5G8K-6" vertex="1">
<mxGeometry x="37" y="14" width="40" height="10" as="geometry" />
Expand Down
18 changes: 12 additions & 6 deletions src/gui/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ set(gui_SOURCES
windows/messages/messagesview.cpp
dialogs/new/newdialog.cpp
ui/hexlineedit.cpp
ui/pow2spinbox.cpp
windows/tlb/tlbview.cpp
windows/tlb/tlbdock.cpp
windows/editor/highlighterasm.cpp
windows/editor/highlighterc.cpp
windows/editor/linenumberarea.cpp
Expand Down Expand Up @@ -52,7 +55,7 @@ set(gui_SOURCES
windows/predictor/predictor_btb_dock.cpp
windows/predictor/predictor_bht_dock.cpp
windows/predictor/predictor_info_dock.cpp
)
)
set(gui_HEADERS
dialogs/about/aboutdialog.h
windows/cache/cachedock.h
Expand All @@ -71,6 +74,9 @@ set(gui_HEADERS
windows/messages/messagesview.h
dialogs/new/newdialog.h
ui/hexlineedit.h
ui/pow2spinbox.h
windows/tlb/tlbview.h
windows/tlb/tlbdock.h
windows/editor/highlighterasm.h
windows/editor/highlighterc.h
windows/editor/linenumberarea.h
Expand Down Expand Up @@ -98,19 +104,19 @@ set(gui_HEADERS
windows/predictor/predictor_btb_dock.h
windows/predictor/predictor_bht_dock.h
windows/predictor/predictor_info_dock.h
)
)
set(gui_UI
dialogs/gotosymbol/gotosymboldialog.ui
dialogs/new/NewDialog.ui
windows/peripherals/peripheralsview.ui
mainwindow/MainWindow.ui
dialogs/new/NewDialogCache.ui
)
)
set(gui_RESOURCES
resources/icons/icons.qrc
resources/samples/samples.qrc
windows/coreview/schemas/schemas.qrc
)
)


if ("${WASM}")
Expand Down Expand Up @@ -160,7 +166,7 @@ set_target_properties(gui PROPERTIES
MACOSX_BUNDLE_BUNDLE_VERSION "${MAIN_PROJECT_VERSION}"
MACOSX_BUNDLE_SHORT_VERSION_STRING "${MAIN_PROJECT_VERSION}"
MACOSX_BUNDLE_ICONFILE ${ICON_NAME}
)
)
# END MACOS

# =============================================================================
Expand All @@ -174,5 +180,5 @@ set_target_properties(gui PROPERTIES
install(TARGETS gui
RUNTIME DESTINATION bin
BUNDLE DESTINATION ${EXECUTABLE_OUTPUT_PATH}
)
)

141 changes: 141 additions & 0 deletions src/gui/dialogs/new/NewDialog.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@
</item>
<item>
<widget class="QStackedWidget" name="config_pages">
<property name="currentIndex">
<number>3</number>
</property>
<widget class="QWidget" name="tab_preset_load">
<property name="accessibleName">
<string>Presets and ELF File</string>
Expand Down Expand Up @@ -263,6 +266,9 @@
<layout class="QVBoxLayout" name="verticalLayout_10">
<item>
<widget class="QGroupBox" name="group_bp">
<property name="enabled">
<bool>true</bool>
</property>
<property name="title">
<string>Branch Predictor</string>
</property>
Expand Down Expand Up @@ -656,6 +662,134 @@
</item>
</layout>
</widget>
<widget class="QWidget" name="tab_virtual_memory">
<property name="accessibleName">
<string>Virtual Memory</string>
</property>
<widget class="QGroupBox" name="group_vm">
<property name="enabled">
<bool>true</bool>
</property>
<property name="geometry">
<rect>
<x>10</x>
<y>10</y>
<width>471</width>
<height>181</height>
</rect>
</property>
<property name="title">
<string>Virtual Memory</string>
</property>
<property name="checkable">
<bool>true</bool>
</property>
<property name="checked">
<bool>true</bool>
</property>
<widget class="QGroupBox" name="tlb_groupBox">
<property name="enabled">
<bool>true</bool>
</property>
<property name="geometry">
<rect>
<x>20</x>
<y>30</y>
<width>431</width>
<height>131</height>
</rect>
</property>
<property name="title">
<string>Translation Lookaside Buffer (TLB)</string>
</property>
<property name="checkable">
<bool>false</bool>
</property>
<layout class="QFormLayout" name="formLayout_2">
<item row="0" column="0">
<widget class="QLabel" name="label_2">
<property name="text">
<string>Number of sets:</string>
</property>
</widget>
</item>
<item row="0" column="1">
<widget class="Pow2SpinBox" name="tlb_number_of_sets">
<property name="minimum">
<number>1</number>
</property>
<property name="maximum">
<number>1024</number>
</property>
<property name="singleStep">
<number>1</number>
</property>
<property name="stepType">
<enum>QAbstractSpinBox::DefaultStepType</enum>
</property>
<property name="value">
<number>1</number>
</property>
<property name="displayIntegerBase">
<number>10</number>
</property>
</widget>
</item>
<item row="1" column="0">
<widget class="QLabel" name="label_5">
<property name="text">
<string>Degree of associativity:</string>
</property>
</widget>
</item>
<item row="1" column="1">
<widget class="QSpinBox" name="tlb_degree_of_associativity">
<property name="minimum">
<number>1</number>
</property>
<property name="singleStep">
<number>1</number>
</property>
<property name="value">
<number>1</number>
</property>
</widget>
</item>
<item row="2" column="0">
<widget class="QLabel" name="label_6">
<property name="text">
<string>Replacement policy:</string>
</property>
</widget>
</item>
<item row="2" column="1">
<widget class="QComboBox" name="tlb_replacement_policy">
<item>
<property name="text">
<string>Random</string>
</property>
</item>
<item>
<property name="text">
<string>Least Recently Used (LRU)</string>
</property>
</item>
<item>
<property name="text">
<string>Least Frequently Used (LFU)</string>
</property>
</item>
<item>
<property name="text">
<string>Pseudo Least Recently Used (PLRU)</string>
</property>
</item>
</widget>
</item>
</layout>
</widget>
</widget>
</widget>
<widget class="QWidget" name="tab_memory">
<property name="accessibleName">
<string>Memory Timings</string>
Expand Down Expand Up @@ -955,6 +1089,13 @@
</item>
</layout>
</widget>
<customwidgets>
<customwidget>
<class>Pow2SpinBox</class>
<extends>QSpinBox</extends>
<header>ui/pow2spinbox.h</header>
</customwidget>
</customwidgets>
<resources/>
<connections/>
</ui>
Loading