First commit

resources/projects/libraries/qt_utils/motion_editor/AddStateDialog.cpp

@@ -32,7 +32,7 @@ AddStateDialog::AddStateDialog(Motion *motion, QWidget *parent) : QDialog(parent
   populateListWidget();
 
   QWidget *buttonsWidget = new QWidget(this);
-  QPushButton *cancelButton = new QPushButton(tr("Cancel"), buttonsWidget);
+  QPushButton *const cancelButton = new QPushButton(tr("Cancel"), buttonsWidget);
   QPushButton *okButton = new QPushButton(tr("Ok"), buttonsWidget);
   QHBoxLayout *hBoxLayout = new QHBoxLayout(buttonsWidget);
   hBoxLayout->addStretch();

resources/projects/libraries/qt_utils/motion_editor/Pose.cpp

@@ -17,7 +17,7 @@ Pose::Pose(const Pose &other) : mName(other.mName), mTime(other.mTime), mIsValid
   int size = other.mStates.size();
   mStates.reserve(size);
   foreach (const MotorTargetState *item, other.mStates) {
-    MotorTargetState *state = new MotorTargetState(*item);
+    MotorTargetState *const state = new MotorTargetState(*item);
     mStates.append(state);
     connect(state, SIGNAL(updated()), this, SLOT(propagateStateUpdate()));
     connect(state, SIGNAL(validChanged()), this, SLOT(updateIsValid()));

resources/projects/libraries/qt_utils/motion_editor/PoseEditor.cpp

@@ -36,7 +36,7 @@ PoseEditor::PoseEditor(Pose *pose, Pose *previousPose, Pose *nextPose, bool fixe
   formLayout->addRow(tr("&Milliseconds:"), mMilliSecondsSpinBox);
 
   QWidget *buttonsWidget = new QWidget(this);
-  QPushButton *cancelButton = new QPushButton(tr("Cancel"), buttonsWidget);
+  QPushButton *const cancelButton = new QPushButton(tr("Cancel"), buttonsWidget);
   QPushButton *okButton = new QPushButton(tr("Ok"), buttonsWidget);
   QHBoxLayout *hBoxLayout = new QHBoxLayout(buttonsWidget);
   hBoxLayout->addStretch();

src/controller/c/g_image.c

@@ -224,7 +224,7 @@ struct ImageData {
   unsigned long *target_data_size;
 };
 
-void g_image_save_to_jpeg_buffer_callback(void *context, void *data, int size) {
+void g_image_save_to_jpeg_buffer_callback(void *context, const void *data, int size) {
   if (!*(((struct ImageData *)context)->target_data))
     *(((struct ImageData *)context)->target_data) = (unsigned char *)malloc(size);
   else

src/controller/c/supervisor.c

@@ -1814,7 +1814,7 @@ static WbNodeRef node_get_from_id(int id, const char *function) {
 
   WbNodeRef result = find_node_by_id(id);
   if (!result) {
-    WbNodeRef node_list_before = node_list;
+    WbNodeRef *const node_list_before = node_list;
     node_id = id;
     wb_robot_flush_unlocked(function);
     if (node_list != node_list_before)
@@ -2313,7 +2313,7 @@ WbFieldRef wb_supervisor_node_get_field_by_index(WbNodeRef node, int index) {
   WbFieldRef result = find_field_by_id(node->id, index, false);
   if (!result) {
     // otherwise: need to talk to Webots
-    WbFieldRef field_list_before = field_list;
+    WbFieldRef *const field_list_before = field_list;
     requested_field_index = index;
     node_ref = node->id;
     wb_robot_flush_unlocked(__FUNCTION__);
@@ -2349,7 +2349,7 @@ WbFieldRef wb_supervisor_node_get_proto_field_by_index(WbNodeRef node, int index
   WbFieldRef result = find_field_by_id(node->id, index, true);
   if (!result) {
     // otherwise: need to talk to Webots
-    WbFieldRef field_list_before = field_list;
+    WbFieldRef *const field_list_before = field_list;
     requested_field_index = index;
     node_ref = node->id;
     allow_search_in_proto = true;

src/webots/app/WbApplication.cpp

@@ -122,7 +122,7 @@ WbApplication::~WbApplication() {
 }
 
 void WbApplication::setup() {
-  WbNodeOperations *nodeOperations = WbNodeOperations::instance();
+  WbNodeOperations *const nodeOperations = WbNodeOperations::instance();
 
   // create and connect WbAnimationRecorder
   WbAnimationRecorder *recorder = WbAnimationRecorder::instance();

src/webots/control/WbControlledWorld.cpp

@@ -46,7 +46,7 @@ WbControlledWorld::WbControlledWorld(WbTokenizer *tokenizer) :
     return;
 
   mNeedToYield = false;
-  foreach (WbRobot *const robot, robots())
+  foreach (const WbRobot *robot, robots()) {
     connect(robot, &WbRobot::startControllerRequest, this, &WbControlledWorld::startController);
 }
 
@@ -195,7 +195,7 @@ void WbControlledWorld::checkIfReadRequestCompleted() {
 
 void WbControlledWorld::step() {
   if (mFirstStep && !mRetryEnabled) {
-    foreach (WbRobot *const robot, robots()) {
+    foreach (const WbRobot *robot, robots()) {
       if (!robot->isControllerStarted())
         startController(robot);
     }

src/webots/core/WbTelemetry.cpp

@@ -71,7 +71,7 @@ void WbTelemetry::sendRequest(const QString &operation) {
   data.append("&build=");
   data.append(QString::number(UNIX_TIMESTAMP).toUtf8());
   request.setHeader(QNetworkRequest::ContentTypeHeader, "application/x-www-form-urlencoded");
-  QNetworkReply *reply = WbNetwork::instance()->networkAccessManager()->post(request, data);
+  QNetworkReply *const reply = WbNetwork::instance()->networkAccessManager()->post(request, data);
   if (id == 0) {
     QEventLoop loop;
     QTimer timer;

src/webots/core/WbWebotsUpdateManager.cpp

@@ -50,7 +50,7 @@ void WbWebotsUpdateManager::cleanup() {
 void WbWebotsUpdateManager::sendRequest() {
   QNetworkRequest request;
   request.setUrl(QUrl("https://api.github.com/repos/cyberbotics/webots/releases/latest"));
-  QNetworkReply *reply = WbNetwork::instance()->networkAccessManager()->get(request);
+  QNetworkReply *const reply = WbNetwork::instance()->networkAccessManager()->get(request);
   connect(reply, &QNetworkReply::finished, this, &WbWebotsUpdateManager::downloadReplyFinished, Qt::UniqueConnection);
 }
 

src/webots/engine/WbSimulationWorld.cpp

@@ -226,7 +226,7 @@ void WbSimulationWorld::step() {
     dImmersionOutlineDestroy(mImmersionGeoms.at(i).outline);
   mImmersionGeoms.clear();
 
-  foreach (WbRobot *const robot, robots()) {
+  foreach (const WbRobot *robot, robots()) {
     if (robots().contains(robot))  // the 'processImmediateMessages' of another robot may have removed/regenerated this robot
       robot->processImmediateMessages();
   }
@@ -400,7 +400,7 @@ void WbSimulationWorld::reset(bool restartControllers) {
   dImmersionLinkGroupEmpty(mCluster->immersionLinkGroup());
   WbSoundEngine::stopAllSources();
   if (restartControllers) {
-    foreach (WbRobot *const robot, robots()) {
+    foreach (const WbRobot *robot, robots()) {
       if (robot->isControllerStarted())
         robot->restartController();
     }

src/webots/gui/WbNewProjectWizard.cpp

@@ -124,7 +124,7 @@ QWizardPage *WbNewProjectWizard::createDirectoryPage() {
   page->setTitle(tr("Directory selection"));
   page->setSubTitle(tr("Please choose a directory for your new project:"));
   mDirEdit = new WbLineEdit(page);
-  QPushButton *chooseButton = new QPushButton(tr("Choose"), page);
+  QPushButton *const chooseButton = new QPushButton(tr("Choose"), page);
   connect(chooseButton, &QPushButton::pressed, this, &WbNewProjectWizard::chooseDirectory);
   QHBoxLayout *layout = new QHBoxLayout(page);
   layout->addWidget(mDirEdit);

src/webots/gui/WbNewVersionDialog.cpp

@@ -132,7 +132,7 @@ WbNewVersionDialog::WbNewVersionDialog() {
   vBoxLayout->addWidget(telemetryBox);
 
   // main button
-  QPushButton *startButton = new QPushButton(tr("Start Webots with the selected theme."));
+  QPushButton *const startButton = new QPushButton(tr("Start Webots with the selected theme."));
   vBoxLayout->addWidget(startButton);
 
   setLayout(vBoxLayout);

src/webots/gui/WbWebotsUpdateDialog.cpp

@@ -25,7 +25,7 @@
 WbWebotsUpdateDialog::WbWebotsUpdateDialog(bool displayCheckBox, QWidget *parent) : QDialog(parent) {
   setWindowTitle(tr("Check for updates"));
 
-  QDialogButtonBox *buttonBox = new QDialogButtonBox(QDialogButtonBox::Ok, Qt::Horizontal, this);
+  QDialogButtonBox *const buttonBox = new QDialogButtonBox(QDialogButtonBox::Ok, Qt::Horizontal, this);
   connect(buttonBox, &QDialogButtonBox::accepted, this, &WbWebotsUpdateDialog::accept);
 
   mLabel = new QLabel(tr("Check for updates..."), this);

src/webots/nodes/WbCadShape.cpp

@@ -118,7 +118,7 @@ void WbCadShape::retrieveMaterials() {
     if (!newUrl.isEmpty()) {
       mObjMaterials.insert(material, newUrl);
       // prepare a downloader
-      WbDownloader *downloader = WbDownloadManager::instance()->createDownloader(QUrl(newUrl), this);
+      WbDownloader *const downloader = WbDownloadManager::instance()->createDownloader(QUrl(newUrl), this);
       connect(downloader, &WbDownloader::complete, this, &WbCadShape::materialDownloadTracker);
       mMaterialDownloaders.push_back(downloader);
     }

src/webots/nodes/WbHinge2Joint.cpp

@@ -582,7 +582,7 @@ void WbHinge2Joint::addDevice2(int index) {
     WbBaseNode *decendant = dynamic_cast<WbBaseNode *>(mDevice2->item(index));
     r->descendantNodeInserted(decendant);
   }
-  WbBrake *brake = dynamic_cast<WbBrake *>(mDevice2->item(index));
+  WbBrake *const brake = dynamic_cast<WbBrake *>(mDevice2->item(index));
   if (brake)
     connect(brake, &WbBrake::brakingChanged, this, &WbHinge2Joint::updateSpringAndDampingConstants, Qt::UniqueConnection);
 }

src/webots/nodes/WbJoint.cpp

@@ -152,7 +152,7 @@ void WbJoint::addDevice(int index) {
     WbBaseNode *decendant = dynamic_cast<WbBaseNode *>(mDevice->item(index));
     r->descendantNodeInserted(decendant);
   }
-  WbBrake *b = dynamic_cast<WbBrake *>(mDevice->item(index));
+  WbBrake *const b = dynamic_cast<WbBrake *>(mDevice->item(index));
   if (b)
     connect(b, &WbBrake::brakingChanged, this, &WbJoint::updateSpringAndDampingConstants, Qt::UniqueConnection);
 }

src/webots/nodes/WbLed.cpp

@@ -107,7 +107,7 @@ void WbLed::findMaterialsAndLights(const WbGroup *group) {
     WbBaseNode *const n = group->child(i);
     // cppcheck-suppress constVariablePointer
     WbLight *lightChild = dynamic_cast<WbLight *>(n);
-    WbGroup *groupChild = dynamic_cast<WbGroup *>(n);
+    WbGroup *const groupChild = dynamic_cast<WbGroup *>(n);
 
     if (n->nodeType() == WB_NODE_SHAPE) {
       const WbAppearance *appearance = dynamic_cast<WbShape *>(n)->appearance();
@@ -120,7 +120,7 @@ void WbLed::findMaterialsAndLights(const WbGroup *group) {
         connect(appearance, &WbAppearance::fieldChanged, this, &WbLed::updateIfNeeded, Qt::UniqueConnection);
         connect(appearance->parentNode(), &WbShape::fieldChanged, this, &WbLed::updateIfNeeded, Qt::UniqueConnection);
       } else {
-        WbPbrAppearance *pbrAppearance = dynamic_cast<WbShape *>(n)->pbrAppearance();
+        WbPbrAppearance *const pbrAppearance = dynamic_cast<WbShape *>(n)->pbrAppearance();
         if (pbrAppearance) {
           mPbrAppearances.append(pbrAppearance);
 

src/webots/nodes/WbMatter.cpp

@@ -361,12 +361,12 @@ void WbMatter::createOdeGeomFromInsertedShapeItem() {
     if (insertedGeom)
       setGeomMatter(insertedGeom);
   } else {  // no Pose in the boundingObject is a parent of this Shape
-    WbIndexedFaceSet *const ifs = dynamic_cast<WbIndexedFaceSet *>(geometry);
+    const WbIndexedFaceSet *const ifs = dynamic_cast<WbIndexedFaceSet *>(geometry);
     if (ifs)
       connect(ifs, &WbIndexedFaceSet::validIndexedFaceSetInserted, shape, &WbShape::geometryInShapeInserted,
               Qt::UniqueConnection);
 
-    WbElevationGrid *const eg = dynamic_cast<WbElevationGrid *>(geometry);
+    const WbElevationGrid *const eg = dynamic_cast<WbElevationGrid *>(geometry);
     if (eg)
       connect(eg, &WbElevationGrid::validElevationGridInserted, shape, &WbShape::geometryInShapeInserted, Qt::UniqueConnection);
 

src/webots/nodes/WbRobot.cpp

@@ -286,7 +286,7 @@ void WbRobot::addDevices(WbNode *node) {
       if (renderingDevice) {
         connect(renderingDevice, &WbBaseNode::isBeingDestroyed, this, &WbRobot::removeRenderingDevice, Qt::UniqueConnection);
         mRenderingDevices.append(renderingDevice);
-        WbAbstractCamera *camera = dynamic_cast<WbAbstractCamera *>(renderingDevice);
+        WbAbstractCamera *const camera = dynamic_cast<WbAbstractCamera *>(renderingDevice);
         if (camera) {
           connect(camera, &WbAbstractCamera::enabled, this, &WbRobot::updateActiveCameras, Qt::UniqueConnection);
           if (camera->isEnabled())
@@ -311,7 +311,7 @@ void WbRobot::addDevices(WbNode *node) {
     return;
   }
 
-  WbSkin *const skin = dynamic_cast<WbSkin *>(node);
+  const WbSkin *skin = dynamic_cast<WbSkin *>(node);
   if (skin) {
     mDevices.append(skin);
     connect(static_cast<WbBaseNode *>(skin), &WbBaseNode::destroyed, this, &WbRobot::updateDevicesAfterDestruction,
@@ -330,7 +330,7 @@ void WbRobot::addDevices(WbNode *node) {
     const WbJoint *const joint = dynamic_cast<WbJoint *>(basicJoint);
     if (joint) {
       const QVector<WbLogicalDevice *> &jointDevices = joint->devices();
-      foreach (WbLogicalDevice *const jointDevice, jointDevices) {
+      foreach (const WbLogicalDevice *jointDevice, jointDevices) {
         if (jointDevice == NULL)
           continue;
         mDevices.append(jointDevice);
@@ -343,9 +343,9 @@ void WbRobot::addDevices(WbNode *node) {
     return;
   }
 
-  WbPropeller *const propeller = dynamic_cast<WbPropeller *>(node);
+  const WbPropeller *propeller = dynamic_cast<const WbPropeller *>(node);
   if (propeller) {
-    WbLogicalDevice *const propellerDevice = propeller->device();
+    const WbLogicalDevice *propellerDevice = propeller->device();
     if (propellerDevice) {
       mDevices.append(propellerDevice);
       connect(static_cast<WbBaseNode *>(propellerDevice), &WbBaseNode::destroyed, this, &WbRobot::updateDevicesAfterDestruction,

src/webots/nodes/WbSolid.cpp

@@ -1580,7 +1580,7 @@ void WbSolid::updateChildren() {
     connect(solid, &WbSolid::destroyed, this, &WbSolid::refreshPhysicsRepresentation, Qt::UniqueConnection);
     connect(solid, &WbSolid::physicsPropertiesChanged, this, &WbSolid::refreshPhysicsRepresentation, Qt::UniqueConnection);
   }
-  foreach (WbBasicJoint *const jointChild, mJointChildren)
+  foreach (const WbBasicJoint *jointChild, mJointChildren)
     connect(jointChild, &WbBasicJoint::endPointChanged, this, &WbSolid::updateChildrenAfterJointEndPointChange,
             Qt::UniqueConnection);
 }

src/webots/nodes/WbTrack.cpp

@@ -132,7 +132,7 @@ void WbTrack::postFinalize() {
   connect(mDeviceField, &WbMFNode::itemInserted, this, &WbTrack::addDevice);
 
   if (childCount() > 0) {
-    WbGroup *group = dynamic_cast<WbGroup *>(child(0));
+    WbGroup *const group = dynamic_cast<WbGroup *>(child(0));
     if (group)
       connect(group, &WbGroup::childrenChanged, this, &WbTrack::updateChildren);
     if (mShape)
@@ -235,7 +235,7 @@ bool WbTrack::findAndConnectAnimatedGeometries(bool connectSignals, QList<WbShap
       return false;
     }
 
-    WbShape *s = dynamic_cast<WbShape *>(node);
+    WbShape *const s = dynamic_cast<WbShape *>(node);
     if (s) {
       if (connectSignals) {
         // material automatically updated
@@ -259,7 +259,7 @@ bool WbTrack::findAndConnectAnimatedGeometries(bool connectSignals, QList<WbShap
       for (int j = 0; j < g->childCount(); ++j)
         geometryNodes.append(g->child(j));
 
-      WbPose *t = dynamic_cast<WbPose *>(g);
+      WbPose *const t = dynamic_cast<WbPose *>(g);
       if (t) {
         t->enablePoseChangedSignal();
         connect(t, &WbPose::poseChanged, this, &WbTrack::updateAnimatedGeometries, Qt::UniqueConnection);
@@ -951,7 +951,7 @@ void WbTrack::exportNodeSubNodes(WbWriter &writer) const {
   // write animated geometries
   if (!writer.isW3d() && !writer.isUrdf() && !isEmpty)
     writer << "\n";
-  isEmpty |= mAnimatedObjectList.isEmpty();
+  isEmpty || mAnimatedObjectList.isEmpty();
 
   exportAnimatedGeometriesMesh(writer);
 

src/webots/nodes/utils/WbNodeOperations.cpp

@@ -112,9 +112,9 @@ WbNodeOperations::OperationResult WbNodeOperations::importNode(WbNode *parentNod
                                                                bool avoidIntersections) {
   setFromSupervisor(origin == FROM_SUPERVISOR);
 
-  WbSFNode *sfnode = dynamic_cast<WbSFNode *>(field->value());
+  const WbSFNode *sfnode = dynamic_cast<WbSFNode *>(field->value());
 #ifndef NDEBUG
-  WbMFNode *mfnode = dynamic_cast<WbMFNode *>(field->value());
+  const WbMFNode *mfnode = dynamic_cast<WbMFNode *>(field->value());
   assert(mfnode || sfnode);
   // index value is assumed to be in range [0, mfnode->size()]
   // user input checked in wb_supervisor_field_import_mf_node_from_string or WbSceneTree
@@ -309,7 +309,7 @@ bool WbNodeOperations::deleteNode(WbNode *node, bool fromSupervisor) {
 
   setFromSupervisor(fromSupervisor);
 
-  if (dynamic_cast<WbSolid *>(node))
+  if (node && dynamic_cast<WbSolid *>(node))
     WbWorld::instance()->awake();
 
   const bool dictionaryNeedsUpdate = WbVrmlNodeUtilities::hasAreferredDefNodeDescendant(node);

src/webots/scene_tree/WbSceneTree.cpp

@@ -1125,7 +1125,7 @@ void WbSceneTree::updateSelection() {
     // quitting Webots
     return;
 
-  WbNodeOperations *nodeOperations = WbNodeOperations::instance();
+  WbNodeOperations *const nodeOperations = WbNodeOperations::instance();
   if (nodeOperations->isFromSupervisor())
     // do not update selection if change come from supervisor
     return;

src/webots/user_commands/WbActionManager.cpp

@@ -1134,7 +1134,7 @@ void WbActionManager::populateActions() {
 }
 
 void WbActionManager::connectActions() {
-  WbSimulationState *state = WbSimulationState::instance();
+  WbSimulationState *const state = WbSimulationState::instance();
 
   connect(state, &WbSimulationState::enabledChanged, this, &WbActionManager::updateEnabled);
 }

src/webots/vrml/WbField.cpp

@@ -81,7 +81,7 @@ WbField::~WbField() {
 
 void WbField::listenToValueSizeChanges() const {
   if (singleType() == WB_SF_NODE) {
-    WbSFNode *sfnode = static_cast<WbSFNode *>(mValue);
+    const WbSFNode *sfnode = static_cast<WbSFNode *>(mValue);
     connect(sfnode, &WbSFNode::changed, this, &WbField::valueSizeChanged, Qt::UniqueConnection);
     return;
   }
@@ -362,7 +362,7 @@ void WbField::redirectTo(WbField *parameter, bool skipCopy) {
   if (!skipCopy)
     mValue->copyFrom(mParameter->value());
 
-  WbMFNode *mfnode = dynamic_cast<WbMFNode *>(mParameter->value());
+  const WbMFNode *mfnode = dynamic_cast<WbMFNode *>(mParameter->value());
   if (mfnode) {
     connect(mfnode, &WbMFNode::itemChanged, mParameter, &WbField::parameterNodeChanged, Qt::UniqueConnection);
     connect(mfnode, &WbMFNode::itemInserted, mParameter, &WbField::parameterNodeInserted, Qt::UniqueConnection);

src/webots/vrml/WbNode.cpp

@@ -208,15 +208,15 @@ WbNode::WbNode(const WbNode &other) :
 
   // copy fields
   foreach (const WbField *f, other.fields()) {
-    WbField *copy = new WbField(*f, this);
+    WbField *const copy = new WbField(*f, this);
     mFields.append(copy);
     connect(copy, &WbField::valueChanged, this, &WbNode::notifyFieldChanged);
   }
 
   // copy parameters
   if (other.mProto) {
     foreach (const WbField *parameter, other.parameters()) {
-      WbField *copy = new WbField(*parameter, this);
+      WbField *const copy = new WbField(*parameter, this);
       mParameters.append(copy);
       connect(copy, &WbField::valueChanged, this, &WbNode::notifyParameterChanged);
     }

src/wren/Node.cpp

@@ -61,7 +61,7 @@ namespace wren {
   Node::Node() : mIsVisible(true), mIsAabbDirty(true), mIsBoundingSphereDirty(true), mParent(NULL) {
   }
 
-  Node::Node(Node *source) :
+  Node::Node(const Node *source) :
     mIsVisible(source->mIsVisible),
     mIsAabbDirty(source->mIsAabbDirty),
     mIsBoundingSphereDirty(source->mIsBoundingSphereDirty),