Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ros2ControlSystem.cpp: correct joint.acceleration #1023

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

onionsflying
Copy link
Contributor

Description
I noticed that the sign of the acceleration was reversed.

Copy link
Member

@lukicdarkoo lukicdarkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@lukicdarkoo lukicdarkoo added the bug Something isn't working label Dec 29, 2024
Copy link
Member

@lukicdarkoo lukicdarkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also make an entry in the changelog?

@onionsflying
Copy link
Contributor Author

Sure, I updated the changelog.

Copy link
Member

@lukicdarkoo lukicdarkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@onionsflying
Copy link
Contributor Author

@lukicdarkoo Hi, could this PR be merged?

@lukicdarkoo
Copy link
Member

@onionsflying I will merge for you as some of the CI tests are failing (not related to your changes). Thank you!

@lukicdarkoo lukicdarkoo merged commit 9d870d1 into cyberbotics:master Jan 14, 2025
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants