[dagster-azure] fix azure compute log manager credentialing #26157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpeng817
force-pushed
the
dpeng817/fix_compute_log_manager
branch
from
a5d9730
to
340c5f4
Compare
mlarose
approved these changes
Nov 27, 2024
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
I think the existing credentialing here is busted -
BlobServiceClientdoesn't accept a bare secret string anymore - instead, in order to pass a secret, you need a fully qualified dictionary.Technically this is a breaking change but I don't see how it could be working right now anyway.
How I Tested These Changes
Tested manually with a local dagster installation running the compute log manager live. Downstream I'll add actual integration tests.